1275455 - Containers hamburger menu doesn’t have icons

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Bram Pitoyo [:bram]]

Attachment: containers hamburger menu (mac)

This also applies to when you put the containers icon on the toolbar. The menu that pops open doesn’t have icons in it.

Comment 1

[Bram Pitoyo [:bram]]

Attachment: containers toolbar menu (mac)

Comment 2

[Kamil Jozwiak [:kjozwiak]]

Attachment: hamburgerContainers.png

It looks like Ubuntu 14.04.4 LTS is affected as well.. The icons are missing from the following locations:

* File Menu (File -> New Container Tab)
* Hamburger Menu (Hamburger Icon -> Open Container Tab)

Used the following build:

* fx49.0a1 buildId: 20160524073714, changeset: 829d3be6ba64
* https://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-24-07-37-14-mozilla-central/

Comment 3

[Jonathan Kingston [:jkt] he/him]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a246982f6cbf

Comment 4

[Jonathan Kingston [:jkt] he/him]

Attachment: MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu

Review commit: https://reviewboard.mozilla.org/r/55334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55334/

Comment 5

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8756688 [details]
MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu

This covers the customisable icon menu icons for containers but not the file menu for linux as that was resolved in: 1248639

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8756688 [details]
MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu

https://reviewboard.mozilla.org/r/55334/#review52814

Comment 7

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8756688 [details]
MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55334/diff/1-2/

Comment 8

[Jonathan Kingston [:jkt] he/him]

:baku - I updated the selector for perf reasons, not sure if you need another r+ on this or if that is ok? Thanks.

Comment 9

[Andrea Marchesini [:baku]]

It's ok.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a48b194e35b
Adding in icons for containers in customisable UI menu. r=baku

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a48b194e35b