Closed
Bug 1275455
Opened 8 years ago
Closed 8 years ago
Containers hamburger menu doesn’t have icons
Categories
(Core :: DOM: Security, defect, P1)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: bram, Assigned: jkt)
Details
(Whiteboard: [domsecurity-active])
Attachments
(4 files)
containers hamburger menu (mac)
This also applies to when you put the containers icon on the toolbar. The menu that pops open doesn’t have icons in it.
|
Reporter | |
Comment 1•8 years ago
|
||
|
||
Comment 2•8 years ago
|
||
It looks like Ubuntu 14.04.4 LTS is affected as well.. The icons are missing from the following locations: * File Menu (File -> New Container Tab) * Hamburger Menu (Hamburger Icon -> Open Container Tab) Used the following build: * fx49.0a1 buildId: 20160524073714, changeset: 829d3be6ba64 * https://archive.mozilla.org/pub/firefox/nightly/2016/05/2016-05-24-07-37-14-mozilla-central/
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jkingston
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a246982f6cbf
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/55334/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/55334/
|
|
Assignee | |
Comment 5•8 years ago
|
||
Comment on attachment 8756688 [details] MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu This covers the customisable icon menu icons for containers but not the file menu for linux as that was resolved in: 1248639
Attachment #8756688 -
Flags: review?(mozbugs)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8756688 -
Flags: review?(mozbugs) → review?(amarchesini)
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
|
||
Updated•8 years ago
|
Attachment #8756688 -
Flags: review?(amarchesini) → review+
|
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8756688 [details] MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu https://reviewboard.mozilla.org/r/55334/#review52814
|
||
Updated•8 years ago
|
Whiteboard: [domsecurity-active]
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8756688 [details] MozReview Request: Bug 1275455 - Adding in icons for containers in customisable UI menu Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55334/diff/1-2/
|
|
Assignee | |
Comment 8•8 years ago
|
||
:baku - I updated the selector for perf reasons, not sure if you need another r+ on this or if that is ok? Thanks.
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3a48b194e35b Adding in icons for containers in customisable UI menu. r=baku
Keywords: checkin-needed
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3a48b194e35b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•