1275468 - use the query-string instead of the hash-fragment for search parameters

Status: RESOLVED FIXED

(Webtools Graveyard :: Phonebook, defect)

Description

[:glob ✱]

mozilla's single signon solution doesn't carry hash-fragments through the authentication process, so using a firefox keyword bookmark to quickly search the phonebook is no longer possible.

getting okta fixed is bug 1264176, but it may be quicker to update the phonebook to use the query-string instead of the hash-fragment.  of course we'd need to support both, but the query-string should be the default imho.

Comment 1

[Chris H-C :chutten]

Maybe file a PR? https://github.com/mozilla/phonebook/pulls

Comment 2

[:glob ✱]

https://github.com/mozilla/phonebook/pull/27

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/phonebook

https://github.com/mozilla/phonebook/commit/0b9b0d69e831ad4ff07156c198f045cfb8c5a294
Bug 1275468: use the query-string instead of the hash-fragment for search parameters

https://github.com/mozilla/phonebook/commit/802a1055f43952087308a37ca17d79f7d2d8f82a
Merge pull request #27 from globau/master

Bug 1275468: use the query-string instead of the hash-fragment for search parameters

Comment 4

[:glob ✱]

i didn't take into account searching on the org tree page.  will look at this later today.

Comment 5

[:glob ✱]

https://github.com/mozilla/phonebook/pull/29

Comment 6

[:Atoll]

Pushed to stage, thanks.

Comment 7

[:Atoll]

Deployed to prod. Browsers may cache the JS file for a while, but it's backwards-compatible until they pick up the change.