Closed Bug 1275554 Opened 5 years ago Closed 4 years ago

MediaEngine's mImage value is sometimes released too late in shutdown (final-CC)

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jesup, Assigned: jesup)

Details

Attachments

(1 file)

Sometimes if you have active captures and close a browser, you get an assert from gfx about a texture being released too late in shutdown (final-cc).  This is due to the mImage value.  It's somewhat unclear why this isn't cleared out earlier, but that might be a race condition.
MozReview-Commit-ID: GNU7p3CyzjH
Attachment #8756319 - Flags: review?(pehrsons)
Rank: 19
Priority: -- → P1
Comment on attachment 8756319 [details] [diff] [review]
clear mImage aggressively when no longer needed

Review of attachment 8756319 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Attachment #8756319 - Flags: review?(pehrsons) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5997ad4005f9
clear mImage aggressively when no longer needed r=perhsons
https://hg.mozilla.org/mozilla-central/rev/5997ad4005f9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
jesup, is this something you might want to uplift to 51 ? Thanks!
Flags: needinfo?(rjesup)
Comment on attachment 8756319 [details] [diff] [review]
clear mImage aggressively when no longer needed

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Crashes from the GFX code (asserts) in debug builds (race conditio)

[Describe test coverage new/current, TreeHerder]: We haven't seen it in treeherder, just local tests

[Risks and why]: virtually no risk, just moves where things are released to be earlier instead of on destruction.  Risk would only be of nullptr references (and we've baked a long time)

[String/UUID change made/needed]: none.
Flags: needinfo?(rjesup)
Attachment #8756319 - Flags: approval-mozilla-aurora?
Comment on attachment 8756319 [details] [diff] [review]
clear mImage aggressively when no longer needed

Fix a potential crash. Take it in 51 aurora.
Attachment #8756319 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.