1275554 - MediaEngine's mImage value is sometimes released too late in shutdown (final-CC)

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

Sometimes if you have active captures and close a browser, you get an assert from gfx about a texture being released too late in shutdown (final-cc).  This is due to the mImage value.  It's somewhat unclear why this isn't cleared out earlier, but that might be a race condition.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: clear mImage aggressively when no longer needed

MozReview-Commit-ID: GNU7p3CyzjH

Comment 2

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8756319 [details] [diff] [review]
clear mImage aggressively when no longer needed

Review of attachment 8756319 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5997ad4005f9
clear mImage aggressively when no longer needed r=perhsons

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5997ad4005f9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5997ad4005f9

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

jesup, is this something you might want to uplift to 51 ? Thanks!

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8756319 [details] [diff] [review]
clear mImage aggressively when no longer needed

Approval Request Comment
[Feature/regressing bug #]: N/A

[User impact if declined]: Crashes from the GFX code (asserts) in debug builds (race conditio)

[Describe test coverage new/current, TreeHerder]: We haven't seen it in treeherder, just local tests

[Risks and why]: virtually no risk, just moves where things are released to be earlier instead of on destruction.  Risk would only be of nullptr references (and we've baked a long time)

[String/UUID change made/needed]: none.

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8756319 [details] [diff] [review]
clear mImage aggressively when no longer needed

Fix a potential crash. Take it in 51 aurora.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6bd4900e44d64e0fc3f87494b0e0952f42a2ae19