If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add description caching tests.

RESOLVED FIXED in Firefox 49

Status

()

Core
Disability Access APIs
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Continuing e10s compatible tests effort: adding description caching tests inspired by https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/test_descr.html
(Assignee)

Comment 1

a year ago
Created attachment 8756386 [details]
MozReview Request: Bug 1275586 - adding description caching tests. r=eeejay

Review commit: https://reviewboard.mozilla.org/r/55144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55144/
Attachment #8756386 - Flags: review?(eitan)
Attachment #8756386 - Flags: review?(eitan) → review+
Comment on attachment 8756386 [details]
MozReview Request: Bug 1275586 - adding description caching tests. r=eeejay

https://reviewboard.mozilla.org/r/55144/#review51904

This looks great! Big fan..

::: accessible/tests/browser/browser_caching_description.js:157
(Diff revision 1)
> +          yield invokeSetAttribute(browser, 'image', attr, value);
> +        }
> +      }
> +      yield onUpdate;
> +      // When attribute change (alt) triggers reorder event, accessible will
> +      // become defunct.

That's strange behavior. Shouldn't an alt change just be a name change? The tree doesn't change. Does it?
(Assignee)

Comment 3

a year ago
(In reply to Eitan Isaacson [:eeejay] from comment #2)
> Comment on attachment 8756386 [details]
> MozReview Request: Bug 1275586 - adding description caching tests. r=eeejay
> 
> https://reviewboard.mozilla.org/r/55144/#review51904
> 
> This looks great! Big fan..
> 
> ::: accessible/tests/browser/browser_caching_description.js:157
> (Diff revision 1)
> > +          yield invokeSetAttribute(browser, 'image', attr, value);
> > +        }
> > +      }
> > +      yield onUpdate;
> > +      // When attribute change (alt) triggers reorder event, accessible will
> > +      // become defunct.
> 
> That's strange behavior. Shouldn't an alt change just be a name change? The
> tree doesn't change. Does it?

I believe this is specific to image accessibles and alt attributes only. At least that's what comments in original mochitests suggest: whenever alt attribute is removed/added, it triggers show/hide/reorder sequence.
(Assignee)

Comment 4

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b505e0c2334

Comment 5

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbcbc3e1aa5b

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fbcbc3e1aa5b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.