Closed Bug 1275613 Opened 4 years ago Closed 4 years ago

Jobs with a "file_patterns" clause should automatically be scheduled if their task definition changes

Categories

(Taskcluster Graveyard :: Scheduler, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

Currently you can tell a job to run only when certain file patterns have been modified. But unless the task definition of this job is explicitly listed, the job won't run when making changes to it!

I think it's safe to assume that we want to run a job every time it's definition changes, so we should just do this automatically.

We should also automatically run the job when a parent task.yml is modified, and potentially even when its docker image is modified. But I'm going to punt on these two for now as I don't see any easy way to implement it.
Currently, jobs which has 'file_patterns' set will only be run if a file matching one
of those patterns has been modified. This means that unless the task definition of the
job was explicitly included in those 'file_patterns', the job won't run when we modify
it!

I think it is safe to assume that when making changes to a job's task, we want it to be
run no matter what. So let's add the task definition to 'file_patterns' automatically.

Here's a try run which modifies the marionette harness task:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=01e6cf9d8599c64d61ac8ecb5320c1c4209e0a8b

Review commit: https://reviewboard.mozilla.org/r/55164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55164/
Attachment #8756414 - Flags: review?(dustin)
Attachment #8756414 - Flags: review?(dustin) → review+
Comment on attachment 8756414 [details]
MozReview Request: Bug 1275613 - Always schedule a 'file_patterns' job when its task definition has changed, r?dustin

https://reviewboard.mozilla.org/r/55164/#review51818
https://hg.mozilla.org/mozilla-central/rev/9bf50e4ab8ee
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Taskcluster → Taskcluster Graveyard
You need to log in before you can comment on or make changes to this bug.