Closed Bug 1275623 Opened 9 years ago Closed 9 years ago

Android Nightly builds broken due to passing "default" into --revision

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(firefox49 fixed)

RESOLVED FIXED
Tracking Status
firefox49 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(2 files)

Regression from bug 1274693. Patch coming shortly.
Attachment #8756428 - Flags: review?(jlund)
Comment on attachment 8756428 [details] MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund https://reviewboard.mozilla.org/r/55168/#review51858 ::: testing/mozharness/mozharness/mozilla/l10n/locales.py:230 (Diff revision 1) > tag = c.get('hg_l10n_tag', 'default') > if self.l10n_revisions.get(locale): > tag = self.l10n_revisions[locale] > locale_repos.append({ > 'repo': "%s/%s" % (hg_l10n_base, locale), > - 'revision': tag, > + 'branch': tag, taking a deeper look, we have a number of places that uses 'revision' to pass 'default' and use MercurialVCS (robustcheckout): https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to [0] if we don't set 'vcs' we almost always use the default: 'hg' https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#146
> iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set > 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to *points us to MercurialVCS and eventually robustcheckout
https://reviewboard.mozilla.org/r/55168/#review51858 > taking a deeper look, we have a number of places that uses 'revision' to pass 'default' and use MercurialVCS (robustcheckout): https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true > > iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to > > [0] if we don't set 'vcs' we almost always use the default: 'hg' https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#146 over irc gps and I discussed addressing the other edge cases in follow up bug. I'm mainly concerned with merge, release, and single_locale configs
Comment on attachment 8756428 [details] MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund https://reviewboard.mozilla.org/r/55168/#review51934
Attachment #8756428 - Flags: review+
See Also: → 1274092
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Gps: can you take a look, its tier2 so no backout right now but we should fix this
Flags: needinfo?(gps)
this is mobile_l10n.py that is using single_locale/mozilla-central_android-api-15.py I think the l10n.py catch all fix doesn't catch all. maybe mobile_l10n.py doesn't use that for the repo that's failing to checkout. I haven't poked too deep yet. I imagine we can just update the remaining vcs_configs defined here that are using 'hg': https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true
Comment on attachment 8758456 [details] MozReview Request: Bug 1275623 - Use "branch" instead of "revision" to pass symbolic revisions; r?jlund https://reviewboard.mozilla.org/r/56668/#review53418 should just work®
Attachment #8758456 - Flags: review?(jlund) → review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d86e8362b36 Use "branch" instead of "revision" to pass symbolic revisions; r=jlund
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
I see green N's on central for Android builds. So I think this is back to normal now.
Flags: needinfo?(gps)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: