Closed
Bug 1275623
Opened 9 years ago
Closed 9 years ago
Android Nightly builds broken due to passing "default" into --revision
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
Details
Attachments
(2 files)
Regression from bug 1274693. Patch coming shortly.
Assignee | ||
Comment 1•9 years ago
|
||
This is a regression from cd58054bde90 (bug 1274693).
Review commit: https://reviewboard.mozilla.org/r/55168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55168/
Attachment #8756428 -
Flags: review?(jlund)
Updated•9 years ago
|
Attachment #8756428 -
Flags: review?(jlund)
Comment 2•9 years ago
|
||
Comment on attachment 8756428 [details]
MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund
https://reviewboard.mozilla.org/r/55168/#review51858
::: testing/mozharness/mozharness/mozilla/l10n/locales.py:230
(Diff revision 1)
> tag = c.get('hg_l10n_tag', 'default')
> if self.l10n_revisions.get(locale):
> tag = self.l10n_revisions[locale]
> locale_repos.append({
> 'repo': "%s/%s" % (hg_l10n_base, locale),
> - 'revision': tag,
> + 'branch': tag,
taking a deeper look, we have a number of places that uses 'revision' to pass 'default' and use MercurialVCS (robustcheckout): https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true
iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to
[0] if we don't set 'vcs' we almost always use the default: 'hg' https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#146
Comment 3•9 years ago
|
||
> iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set
> 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to
*points us to MercurialVCS and eventually robustcheckout
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/55168/#review51858
> taking a deeper look, we have a number of places that uses 'revision' to pass 'default' and use MercurialVCS (robustcheckout): https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true
>
> iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to
>
> [0] if we don't set 'vcs' we almost always use the default: 'hg' https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#146
over irc gps and I discussed addressing the other edge cases in follow up bug. I'm mainly concerned with merge, release, and single_locale configs
Comment 5•9 years ago
|
||
Comment on attachment 8756428 [details]
MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund
https://reviewboard.mozilla.org/r/55168/#review51934
Attachment #8756428 -
Flags: review+
Comment 7•9 years ago
|
||
bugherder |
Comment 8•9 years ago
|
||
Looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=4d63dde701b47b8661ab7990f197b6b60e543839&filter-job_group_symbol=L10n&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false, this isn't quite good enough yet.
The single-locale Android builds are still burning.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•9 years ago
|
||
Gps: can you take a look, its tier2 so no backout right now but we should fix this
Flags: needinfo?(gps)
Comment 10•9 years ago
|
||
this is mobile_l10n.py that is using single_locale/mozilla-central_android-api-15.py
I think the l10n.py catch all fix doesn't catch all. maybe mobile_l10n.py doesn't use that for the repo that's failing to checkout. I haven't poked too deep yet. I imagine we can just update the remaining vcs_configs defined here that are using 'hg': https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true
Assignee | ||
Comment 11•9 years ago
|
||
robustcheckout barfs on symbolic revisions when using "revision."
Review commit: https://reviewboard.mozilla.org/r/56668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56668/
Attachment #8758456 -
Flags: review?(jlund)
Comment 12•9 years ago
|
||
Comment on attachment 8758456 [details]
MozReview Request: Bug 1275623 - Use "branch" instead of "revision" to pass symbolic revisions; r?jlund
https://reviewboard.mozilla.org/r/56668/#review53418
should just work®
Attachment #8758456 -
Flags: review?(jlund) → review+
Comment 13•9 years ago
|
||
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d86e8362b36
Use "branch" instead of "revision" to pass symbolic revisions; r=jlund
Comment 14•9 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 15•9 years ago
|
||
I see green N's on central for Android builds. So I think this is back to normal now.
Flags: needinfo?(gps)
You need to log in
before you can comment on or make changes to this bug.
Description
•