1275623 - Android Nightly builds broken due to passing "default" into --revision

Status: RESOLVED FIXED

Description

[Gregory Szorc [:gps]]

Regression from bug 1274693. Patch coming shortly.

Comment 1

[Gregory Szorc [:gps]]

Created attachment 8756428 [details]
MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund

This is a regression from cd58054bde90 (bug 1274693).

Review commit: https://reviewboard.mozilla.org/r/55168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55168/

Comment 2

[Jordan Lund (:jlund) PTO until Oct 1st]

Comment on attachment 8756428 [details]
MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund

https://reviewboard.mozilla.org/r/55168/#review51858

::: testing/mozharness/mozharness/mozilla/l10n/locales.py:230
(Diff revision 1)
>              tag = c.get('hg_l10n_tag', 'default')
>              if self.l10n_revisions.get(locale):
>                  tag = self.l10n_revisions[locale]
>              locale_repos.append({
>                  'repo': "%s/%s" % (hg_l10n_base, locale),
> -                'revision': tag,
> +                'branch': tag,

taking a deeper look, we have a number of places that uses 'revision' to pass 'default' and use MercurialVCS (robustcheckout): https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true

iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to 

[0] if we don't set 'vcs' we almost always use the default: 'hg' https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#146

Comment 3

[Jordan Lund (:jlund) PTO until Oct 1st]

> iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set
> 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to 
*points us to MercurialVCS and eventually robustcheckout

Comment 4

[Jordan Lund (:jlund) PTO until Oct 1st]

https://reviewboard.mozilla.org/r/55168/#review51858

> taking a deeper look, we have a number of places that uses 'revision' to pass 'default' and use MercurialVCS (robustcheckout): https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true
> 
> iiuc, any of these places that explicitly uses 'vcs': 'hg', or don't set 'vcs'[0] will need to s/revision/branch/ as 'hg' points us to 
> 
> [0] if we don't set 'vcs' we almost always use the default: 'hg' https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/base/vcs/vcsbase.py#146

over irc gps and I discussed addressing the other edge cases in follow up bug. I'm mainly concerned with merge, release, and single_locale configs

Comment 5

[Jordan Lund (:jlund) PTO until Oct 1st]

Comment on attachment 8756428 [details]
MozReview Request: Bug 1275623 - Don't use --revision to pass symbolic revisions; r?jlund

https://reviewboard.mozilla.org/r/55168/#review51934

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42a7a846a11b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/42a7a846a11b

Comment 8

[Axel Hecht [:Pike]]

Looking at https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=4d63dde701b47b8661ab7990f197b6b60e543839&filter-job_group_symbol=L10n&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false, this isn't quite good enough yet.

The single-locale Android builds are still burning.

Comment 9

[Carsten Book [:Tomcat]]

Gps: can you take a look, its tier2 so no backout right now but we should fix this

Comment 10

[Jordan Lund (:jlund) PTO until Oct 1st]

this is mobile_l10n.py that is using single_locale/mozilla-central_android-api-15.py

I think the l10n.py catch all fix doesn't catch all. maybe mobile_l10n.py doesn't use that for the repo that's failing to checkout. I haven't poked too deep yet. I imagine we can just update the remaining vcs_configs defined here that are using 'hg': https://dxr.mozilla.org/mozilla-central/search?q=path%3Amozharness+%22revision%22%3A+%22default%22&redirect=true

Comment 11

[Gregory Szorc [:gps]]

Created attachment 8758456 [details]
MozReview Request: Bug 1275623 - Use "branch" instead of "revision" to pass symbolic revisions; r?jlund

robustcheckout barfs on symbolic revisions when using "revision."

Review commit: https://reviewboard.mozilla.org/r/56668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56668/

Comment 12

[Jordan Lund (:jlund) PTO until Oct 1st]

Comment on attachment 8758456 [details]
MozReview Request: Bug 1275623 - Use "branch" instead of "revision" to pass symbolic revisions; r?jlund

https://reviewboard.mozilla.org/r/56668/#review53418

should just work®

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d86e8362b36
Use "branch" instead of "revision" to pass symbolic revisions; r=jlund

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d86e8362b36

Comment 15

[Gregory Szorc [:gps]]

I see green N's on central for Android builds. So I think this is back to normal now.