Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
bug 1275622 changes the name of the updater binary on mac. We should reflect the change in our update verify scripts
(Assignee)

Comment 1

3 years ago
Created attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

Review commit: https://reviewboard.mozilla.org/r/55184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55184/
Attachment #8756446 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Assignee: nobody → rail
(In reply to Rail Aliiev [:rail] from comment #0)
> bug 1275622 changes the name of the updater binary on mac. We should reflect
> the change in our update verify scripts

Just to clarify, it's bug 394984 that changed the name of the binary. Bug 1275622 fixes artifact builds that got busted by that change.
(Assignee)

Comment 3

3 years ago
Oh, right..
Depends on: 394984
No longer depends on: 1275622
Comment on attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

https://reviewboard.mozilla.org/r/55184/#review52144

Pretty sure you need a fix before landing, but r+ with that.

::: release/common/check_updates.sh:28
(Diff revision 1)
>    fi
>    
>    case $update_platform in
>        Darwin_ppc-gcc | Darwin_Universal-gcc3 | Darwin_x86_64-gcc3 | Darwin_x86-gcc3-u-ppc-i386 | Darwin_x86-gcc3-u-i386-x86_64 | Darwin_x86_64-gcc3-u-i386-x86_64) 
>            platform_dirname="*.app"
> -          updater="Contents/MacOS/updater.app/Contents/MacOS/updater"
> +          updaters="Contents/MacOS/updater.app/Contents/MacOS/updater updater.app/Contents/MacOS/org.mozilla.updater"

Don't you need a Contents/MacOS/ prefix on the new location ?
Attachment #8756446 - Flags: review?(nthomas) → review+
(Assignee)

Comment 5

3 years ago
Comment on attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55184/diff/1-2/
(Assignee)

Comment 6

3 years ago
(In reply to Nick Thomas [:nthomas] from comment #4)
> Don't you need a Contents/MacOS/ prefix on the new location ?

Good catch. Of course I do! Too many Contents/MacOS in the name :)
(Assignee)

Comment 7

3 years ago
Comment on attachment 8756446 [details]
MozReview Request: Bug 1275632 - Adjust mac update verify scripts to use updater.app/Contents/MacOS/org.mozilla.updater r=nthomas

https://hg.mozilla.org/build/tools/rev/5bc73d00a723
Attachment #8756446 - Flags: checked-in+
(Assignee)

Comment 8

3 years ago
worked fine in 47.0b9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.