Closed
Bug 1275638
Opened 6 years ago
Closed 6 years ago
Upload library as build artifact for SM(pkg)
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
844 bytes,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
Follow up to bug 1273917. We should upload the built library as an artifact of the build.
Updated•6 years ago
|
Updated•6 years ago
|
Iteration: 49.3 - Jun 6 → 50.1
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8761814 -
Flags: review?(sphink)
Assignee | ||
Comment 2•6 years ago
|
||
Try push which should run SM(pkg) and now also upload libmozjs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2e1e7eda8e3
Assignee | ||
Comment 3•6 years ago
|
||
From that try push's decision task logs:
> scheduling tasks/builds/sm_package.yml because pattern js/src/** matches js/src/make-source-package.sh
And yet, no SM(pkg) is running and the try push is reported as 100% complete...
Comment 4•6 years ago
|
||
I don't know if we can select it in try syntax... I've always used all-platform all-builds try runs to test it.
Assignee | ||
Comment 5•6 years ago
|
||
(In reply to :Ms2ger from comment #4) > I don't know if we can select it in try syntax... I've always used > all-platform all-builds try runs to test it. The try syntax from that push worked when I was finishing the SM(pkg) patch...
Comment 6•6 years ago
|
||
Comment on attachment 8761814 [details] [diff] [review] Move libmozjs to the upload directory Review of attachment 8761814 [details] [diff] [review]: ----------------------------------------------------------------- ::: taskcluster/scripts/builder/build-sm-package.sh @@ +22,5 @@ > RUN_MAKE_CHECKS=false AUTOMATION=1 ./devtools/automation/autospider.sh $SPIDERMONKEY_VARIANT > popd > > # Copy artifacts for upload by TaskCluster > +cp -rL ./mozjs-*/obj-spider/dist/bin/{js,jsapi-tests,js-gdb.py,libmozjs*} $UPLOAD_DIR Good enough for now. Someday, we'll want to make this more platform-independent.
Attachment #8761814 -
Flags: review?(sphink) → review+
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8782b81c1b05 Move libmozjs to the upload directory; r=sfink
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8782b81c1b05
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•6 years ago
|
Whiteboard: [devtools-html]
Comment 9•6 years ago
|
||
(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #3) > From that try push's decision task logs: > > > scheduling tasks/builds/sm_package.yml because pattern js/src/** matches js/src/make-source-package.sh > > And yet, no SM(pkg) is running and the try push is reported as 100% > complete... I can't speak to that log message, but I do know that pushing with -p sm-package (not -p sm-pkg) will trigger that build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=57a3c1ec303b
You need to log in
before you can comment on or make changes to this bug.
Description
•