1275638 - Upload library as build artifact for SM(pkg)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Follow up to bug 1273917.

We should upload the built library as an artifact of the build.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Move libmozjs to the upload directory

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push which should run SM(pkg) and now also upload libmozjs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2e1e7eda8e3

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

From that try push's decision task logs:

> scheduling tasks/builds/sm_package.yml because pattern js/src/** matches js/src/make-source-package.sh

And yet, no SM(pkg) is running and the try push is reported as 100% complete...

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I don't know if we can select it in try syntax... I've always used all-platform all-builds try runs to test it.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

(In reply to :Ms2ger from comment #4)
> I don't know if we can select it in try syntax... I've always used
> all-platform all-builds try runs to test it.

The try syntax from that push worked when I was finishing the SM(pkg) patch...

Comment 6

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8761814 [details] [diff] [review]
Move libmozjs to the upload directory

Review of attachment 8761814 [details] [diff] [review]:
-----------------------------------------------------------------

::: taskcluster/scripts/builder/build-sm-package.sh
@@ +22,5 @@
>  RUN_MAKE_CHECKS=false AUTOMATION=1 ./devtools/automation/autospider.sh $SPIDERMONKEY_VARIANT
>  popd
>  
>  # Copy artifacts for upload by TaskCluster
> +cp -rL ./mozjs-*/obj-spider/dist/bin/{js,jsapi-tests,js-gdb.py,libmozjs*} $UPLOAD_DIR

Good enough for now. Someday, we'll want to make this more platform-independent.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8782b81c1b05
Move libmozjs to the upload directory; r=sfink

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8782b81c1b05

Comment 9

[Steve Fink [:sfink] [:s:]]

(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #3)
> From that try push's decision task logs:
> 
> > scheduling tasks/builds/sm_package.yml because pattern js/src/** matches js/src/make-source-package.sh
> 
> And yet, no SM(pkg) is running and the try push is reported as 100%
> complete...

I can't speak to that log message, but I do know that pushing with -p sm-package (not -p sm-pkg) will trigger that build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=57a3c1ec303b