1275650 - Misleading #titlebar-buttonbox-container -moz-box-align in browser.css?

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Markus Stange [:mstange]]

Bug 941058 added the following code to browser/base/content/browser.css:

/* Because these buttons don't move, they should always be aligned the same,
 * left and right were deprecated, so we have to do work to get it to mean that: */
#titlebar-buttonbox-container:-moz-locale-dir(ltr) {
  -moz-box-align: start;
}
#titlebar-buttonbox-container:-moz-locale-dir(rtl) {
  -moz-box-align: end;
}

But the XUL elements in the titlebar are:

vbox#titlebar
  hbox#titlebar-content
    spacer#titlebar-spacer
    hbox#titlebar-buttonbox-container
      hbox#titlebar-buttonbox
    hbox#titlebar-secondary-buttonbox

So the parent element of #titlebar-button-box-container is a hbox. -moz-box-align determines the alignment on the cross-axis, so in a hbox, it describes the *vertical* alignment.

So does this mean that the titlebar buttons shift down if your chrome is RTL?

Comment 1

[:Gijs (he/him)]

(In reply to Markus Stange [:mstange] from comment #0)
> So does this mean that the titlebar buttons shift down if your chrome is RTL?

When I try this with force rtl, I don't see that happening, so I don't think so. I expect the code is just useless as-is. :-\

Comment 2

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1275650 - remove useless CSS from content browser.css stylesheet, r?mikedeboer

Review commit: https://reviewboard.mozilla.org/r/55262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55262/

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8756582 [details]
MozReview Request: Bug 1275650 - remove useless CSS from content browser.css stylesheet, r?mikedeboer

https://reviewboard.mozilla.org/r/55262/#review52142

Remarkable!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b8adc67d8f4a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b8adc67d8f4a