Closed Bug 1275680 Opened 8 years ago Closed 8 years ago

Garbled text within the flash element with HWA disabled

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
49 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: over68, Assigned: sotaro)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(3 files, 3 obsolete files)

temporary patch - Dump plugin rendering to stderr
876 bytes, patch
Details | Diff | Splinter Review
plugin rendering image of comment 2
8.82 KB, image/png
Details
plugin rendering image of comment 21
223.79 KB, image/png
Details 
Steps to reproduce:

1. Disable hardware acceleration.
2. Restart Firefox.
3. Go to https://dl.dropboxusercontent.com/u/95157096/85f61cf7/7opdfz1nz3.html.
4. Go to the video tape.


Actual results:

Garbled text within the flash element with HWA disabled.

Screenshot https://dl.dropboxusercontent.com/u/95157096/85f61cf7/gekrznfo3e.png
[Tracking Requested - why for this release]:

[Tracking Requested - why for this release]:

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d1ae745b7e3fcb2dbeea4814fa4f907160b1d0e9&tochange=0662b0935257f604567b816af81c369674786190

Regressed by: bug 1254897
Blocks: 1254897
tracking-firefox48: --- → ?
tracking-firefox49: --- → ?
Flags: needinfo?(sotaro.ikeda.g)
Keywords: regression
I tried to reproduce the problem with latest nightly on my 3 win pcs. But failed to reproduce the problem. It seems to related flash plugin invalidation problem.
blinky, can you reproduce the problem on latest nightly and latest flash plugin? Did you enabled multi-process?
Flags: needinfo?(sotaro.ikeda.g) → needinfo?(over68)
I checked how two plugins work. The plugins are different types.
 - Plugin in comment 0: windowless plugin
 - Plugin in comment 1: windowed plugin

 https://developer.mozilla.org/en-US/docs/Plugins/Guide/Plug-in_Basics#Windowed_and_Windowless_Plug-ins
(In reply to Sotaro Ikeda [:sotaro] from comment #5)
> I checked how two plugins work. The plugins are different types.
>  - Plugin in comment 0: windowless plugin
      It created ImageLayer for composition

>  - Plugin in comment 1: windowed plugin
     + non-multi process: It did not create layer.
         The plugin rendered to plugin's window and it is rendered to screen.
         compositor does not handle its rendering.
     + multi-process: ImageLayer is created for scroll handling.
      

> 
>  https://developer.mozilla.org/en-US/docs/Plugins/Guide/Plug-
> in_Basics#Windowed_and_Windowless_Plug-ins
(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> >  - Plugin in comment 1: windowed plugin
>      + non-multi process: It did not create layer.
>          The plugin rendered to plugin's window and it is rendered to screen.
>          compositor does not handle its rendering.
>      + multi-process: ImageLayer is created for scroll handling.

Correction:
   ImageLayer is not created also on multi-process cases.
(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> blinky, can you reproduce the problem on latest nightly and latest flash
> plugin? Did you enabled multi-process?

I can reproduce the problem with the latest nightly build, and with latest Flash Player beta 22.0.0.168.

With hardware acceleration disabled. See https://dl.dropboxusercontent.com/u/95157096/85f61cf7/f8qy73plfe.png


Mozilla/5.0 (Windows NT 6.1; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
https://hg.mozilla.org/mozilla-central/rev/8d0aadfe7da782d415363880008b4ca027686137
Flags: needinfo?(over68)
I can also reproduce with and without multi-process.
Whiteboard: [gfx-noted]
(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> (In reply to Sotaro Ikeda [:sotaro] from comment #5)
> > I checked how two plugins work. The plugins are different types.
> >  - Plugin in comment 0: windowless plugin
>       It created ImageLayer for composition

Contents of the ImageLayer were opaque. From it, the problem seems not related to layer invalidation.
:mattwoodrow, do you have ideas about what could be a possible cause?
Flags: needinfo?(matt.woodrow)
(In reply to blinky from comment #8)
> (In reply to Sotaro Ikeda [:sotaro] from comment #4)
> > blinky, can you reproduce the problem on latest nightly and latest flash
> > plugin? Did you enabled multi-process?
> 
> I can reproduce the problem with the latest nightly build, and with latest
> Flash Player beta 22.0.0.168.

Thanks for the information! I also tried with latest Flash Player beta 22.0.0.168, and confirmed the problem.
Assignee: nobody → sotaro.ikeda.g
With mozregression, I got bug 1259541.

Disabling bug 1254897 or bug 1259541 addressed the problem of comment 0. But both did not address the problem of Comment 1 on current master.
(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> (In reply to Sotaro Ikeda [:sotaro] from comment #6)
> > >  - Plugin in comment 1: windowed plugin
> >      + non-multi process: It did not create layer.
> >          The plugin rendered to plugin's window and it is rendered to screen.
> >          compositor does not handle its rendering.
> >      + multi-process: ImageLayer is created for scroll handling.
> 
> Correction:
>    ImageLayer is not created also on multi-process cases.

With latest Flash Player beta 22.0.0.168, ImageLayer was always created also for comment 1 case.
See Also: → 1276020
Flags: needinfo?(matt.woodrow)
See Also: → 1217665
When plugin async drawing is disabled, the both problems did not happen.
 - dom.ipc.plugins.asyncdrawing.enabled:true
(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> (In reply to Sotaro Ikeda [:sotaro] from comment #6)
> > (In reply to Sotaro Ikeda [:sotaro] from comment #5)
> > > I checked how two plugins work. The plugins are different types.
> > >  - Plugin in comment 0: windowless plugin
> >       It created ImageLayer for composition
> 
> Contents of the ImageLayer were opaque. From it, the problem seems not
> related to layer invalidation.

With latest Flash Player beta 22.0.0.168, ImageLayer's content changed from B8G8R8X8 to B8G8R8A8.
The plugin of comment 1 also caused the problem when hwa enabled and multi-proccess off. From it, comment 0 and comment 1 seem different problem.
Used to dump plugin rendering.
Comment 1 plugin's rendering was already garbled by the plugin. Used attachment 8757346 [details] [diff] [review] to get the image.
From comment 19, the bug focus to the problem of comment 0, since comment 1 is plugins bug.
When I build master firefox on my pc, I saw the rendering problem also with hwa enabled and with multi-process.  By using attachment 8757346 [details] [diff] [review], I checked the flush plugin output, like comment 19, the plugin output already had the problem. In this case, hwa enabled and without multi-process, did not cause the problem.
Attachment #8757347 - Attachment description: plugin rendering image → plugin rendering image of comment 2
Attached image plugin rendering image of comment 21 (obsolete) — 

    
  

        Attachment #8757558 -
        Attachment is obsolete: true

    
    

    
  
From comment 21, I am going to focus to he problem of comment 0 without multi-process.

    
    

    
  
The bus's situation become a bit complex now. I am going to split the comment 24 to different bug.

    
  
Blocks: 1276403

    
  
No longer blocks: 1276403
Depends on: 1276403

    
  

          tracking-firefox48:
          ? → ---

          tracking-firefox49:
          ? → ---

    
    

    
  


  

    
  

        Attachment #8759641 -
        Attachment is patch: true

        Attachment #8759641 -
        Attachment mime type: text/x-patch → text/plain

    
  

        Attachment #8759641 -
        Attachment is obsolete: true

    
  
Depends on: 1276020
See Also: 1276020 → 

    
    

    
  
(In reply to blinky from comment #26)
> This also happens in
> https://dl.dropboxusercontent.com/u/95157096/85f61cf7/ea6zbcyy1i.swf.
> 
> Screenshot
> https://dl.dropboxusercontent.com/u/95157096/85f61cf7/2kstrxxl4k.png

Since bug 1276020 and bug 1276403 fix, the above problem seems to be addressed.

    
    

    
  
From Comment 19 and Comment 23, a remaining problem seems to exist in latest Flash Player beta 22.0.0.168.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        wip patch (obsolete)
        — 
          — Splinter Review
      

    


  

    
  

        Attachment #8774675 -
        Attachment is obsolete: true

    
    

    
  
(In reply to Sotaro Ikeda [:sotaro] from comment #29)
> From Comment 19 and Comment 23, a remaining problem seems to exist in latest
> Flash Player beta 22.0.0.168.

The problem was addressed with Flash Player beta 23.0.0.126 on my pc.

    
    

    
  
blinky, can you check if the problem is addressed?
Flags: needinfo?(over68)

    
    

    
  
I can not reproduce this bug with Flash Player beta 23.0.0.126.
Flags: needinfo?(over68)

    
  
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: