Using filter with job exclusion panel is pretty frustrating

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(1 attachment)

This is for a few reasons:

1. We don't have a debounce filter on the option selection, so it's trying to re-render the whole list every time the user types a character (:parkouss fixed this issue in the test selector in perfherder a few months ago)
2. Our strategy of filtering the list is pretty non-optimal, we could be much faster if we used ng-show as described here: https://tech.small-improvements.com/2013/09/10/angularjs-performance-with-large-lists/

The fundamental problem IMO is that we're just trying to display too much stuff (sort of covered by bug 1266116) but there are some easy things we could do to mitigate the pain of using this interface.
Created attachment 8756499 [details] [review]
[treeherder] wlach:1275695 > mozilla:master
Attachment #8756499 - Flags: review?(cdawson)
Comment on attachment 8756499 [details] [review]
[treeherder] wlach:1275695 > mozilla:master

Nice!  :)
Attachment #8756499 - Flags: review?(cdawson) → review+
Keywords: autoland
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/48c4219b570e4a6fc446af5ca0a7edcc7eab542e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: autoland
Resolution: --- → FIXED

Comment 4

2 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d24c2e7f7e377cbd5137e62da07aeeec9ef3058c
Bug 1275695 - Make filtering in job exclusion panel much faster and smoother
You need to log in before you can comment on or make changes to this bug.