1275695 - Using filter with job exclusion panel is pretty frustrating

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[William Lachance (:wlach)]

This is for a few reasons:

1. We don't have a debounce filter on the option selection, so it's trying to re-render the whole list every time the user types a character (:parkouss fixed this issue in the test selector in perfherder a few months ago)
2. Our strategy of filtering the list is pretty non-optimal, we could be much faster if we used ng-show as described here: https://tech.small-improvements.com/2013/09/10/angularjs-performance-with-large-lists/

The fundamental problem IMO is that we're just trying to display too much stuff (sort of covered by bug 1266116) but there are some easy things we could do to mitigate the pain of using this interface.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1275695 > mozilla:master

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8756499 [details] [review]
[treeherder] wlach:1275695 > mozilla:master

Nice!  :)

Comment 3

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla/treeherder/commit/48c4219b570e4a6fc446af5ca0a7edcc7eab542e

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/d24c2e7f7e377cbd5137e62da07aeeec9ef3058c
Bug 1275695 - Make filtering in job exclusion panel much faster and smoother