Closed Bug 1275698 Opened 4 years ago Closed 4 years ago

Get rid of nsScriptSecurityManager::ScriptAllowed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Now that we have finished up making it not complicated, it's just xpc::Scriptability::Get(aGlobal).Allowed().  We might as well inline it that way and skip all the XPCOMmery.
Comment on attachment 8756514 [details] [diff] [review]
Get rid of nsScriptSecurityManager::ScriptAllowed and replace it with xpc::Scriptability::Get(obj).Allowed() for better performance and less indirection

Review of attachment 8756514 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/nsIScriptSecurityManager.idl
@@ +25,5 @@
>  [ptr] native JSContextPtr(JSContext);
>  [ptr] native JSObjectPtr(JSObject);
>  [ptr] native DomainPolicyClonePtr(mozilla::dom::DomainPolicyClone);
>  
> +[scriptable, uuid(5a373888-2971-4a5a-bc30-6fe3ebe289f6)]

no longer necessary
Attachment #8756514 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/9c3411213ac7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.