1275720 - Remove unused input size argument from SurfacePipeFactory::MakePipe()

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

SurfacePipeFactory::MakePipe() used to make some assertions as to the validity of the resulting pipe, but those assertions have moved into the Configure() methods of the individual SurfaceFilters now (or have simply been rendered unnecessarily by ensuring that the pipelines are correct by construction).

Since we don't use the input size argument to MakePipe() anymore, we should remove it; otherwise it'll just confuse people maintaining the code in the future.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Remove unused input size argument to SurfacePipeFactory::MakePipe().

Here's the patch.

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8756547 [details] [diff] [review]
Remove unused input size argument to SurfacePipeFactory::MakePipe().

Review of attachment 8756547 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely.

Comment 3

[Seth Fowler [:seth] [:s2h]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/354813df8073e8afa0bbff61eb71606dc96290d7
Bug 1275720 - Remove unused input size argument to SurfacePipeFactory::MakePipe(). r=njn

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/354813df8073