Closed Bug 1275720 Opened 4 years ago Closed 4 years ago

Remove unused input size argument from SurfacePipeFactory::MakePipe()

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: seth, Assigned: seth)

Details

Attachments

(1 file)

SurfacePipeFactory::MakePipe() used to make some assertions as to the validity of the resulting pipe, but those assertions have moved into the Configure() methods of the individual SurfaceFilters now (or have simply been rendered unnecessarily by ensuring that the pipelines are correct by construction).

Since we don't use the input size argument to MakePipe() anymore, we should remove it; otherwise it'll just confuse people maintaining the code in the future.
Here's the patch.
Attachment #8756547 - Flags: review?(n.nethercote)
Comment on attachment 8756547 [details] [diff] [review]
Remove unused input size argument to SurfacePipeFactory::MakePipe().

Review of attachment 8756547 [details] [diff] [review]:
-----------------------------------------------------------------

Lovely.
Attachment #8756547 - Flags: review?(n.nethercote) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/354813df8073e8afa0bbff61eb71606dc96290d7
Bug 1275720 - Remove unused input size argument to SurfacePipeFactory::MakePipe(). r=njn
https://hg.mozilla.org/mozilla-central/rev/354813df8073
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.