1275723 - Re-enable/implement the "Debug Script" option in nightly [e10s]'s slow script notification bar.

Status: NEW

(DevTools :: Debugger, enhancement, P3)

Description

[Morgan Phillips [:mrrrgn]]

This is a very useful feature that has gone the way of the dodo since we began the e10s era. There is a process hang monitor in the content thread and a separate "watchdog" thread that we might take advantage of for breaking into a running script.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

:clarkbw, do you consider the "debug script" button from the slow script dialog an important feature from a product perspective?

If so, we should investigate the level of effort here to bring it back for e10s.  (You can check the behavior by using a script like https://bugzilla.mozilla.org/attachment.cgi?id=8830204 in non-e10s mode.)

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

This thing? https://cl.ly/1y0I3O2f082d

I can see it being useful for developers, but if we are shipping that to end users we should be doing something else.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Yes, it ships to all users currently.  In e10s, the "debug script" button which opens the debugger in the slow script doesn't work, so it's not presented.

Currently e10s shows a slimmer notification bar with just stop and wait buttons, so hopefully for we'd just add a "debug" button as well, once the feature works.

So, just trying to gauge priority of reviving "debug script" functionality here for e10s.  We can tweak the dialog UI as needed.

Comment 4

[Bryan Clark (DevTools PM) [:clarkbw]]

I see, just adding the debug button back.

We should probably get that back, but lower priority than most of the items we have in Q1.  Lets revisit this in Q2.

As we move to an add-on / installed world it would be nice to only add this button when someone has the DevTools enabled for their browser.

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The notification bar had a "Debug" button a while ago, but has been removed because it doesn't provide much value for standard user. And developers know how to use DevTools to figure out what is slowing the page down.

We can remove related code from DevTools or just close this bug.

Honza