Closed Bug 1275744 Opened 4 years ago Closed 4 years ago

Update comments to reference MOZ_LOG

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(11 files)

58 bytes, text/x-review-board-request
dbaron
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
58 bytes, text/x-review-board-request
erahm
: review+
Details
We still have a lot of comments mentioning the deprecated NSPR_LOG_MODULES variables. Update them for clarity.
NSPR_LOG_MODULES is deprecated.

Review commit: https://reviewboard.mozilla.org/r/55282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55282/
Attachment #8756625 - Flags: review?(dbaron)
Attachment #8756626 - Flags: review?(erahm)
Attachment #8756627 - Flags: review?(erahm)
Attachment #8756628 - Flags: review?(erahm)
NSPR_LOG_MODULES is deprecated.

Programs in the test directory still use PR_NewLogModule,
so NSPR_LOG_MODULES is accurate for them. Getting these
to link against libxul for LazyLogModule is still to do,
so leave those for now.

Review commit: https://reviewboard.mozilla.org/r/55286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55286/
Comment on attachment 8756626 [details]
Bug 1275744 - Reference MOZ_LOG in xpcom comments.

https://reviewboard.mozilla.org/r/55284/#review52044

Thanks for doing this, lgtm.
Attachment #8756626 - Flags: review?(erahm) → review+
Comment on attachment 8756627 [details]
Bug 1275744 - Reference MOZ_LOG in netwerk comments.

https://reviewboard.mozilla.org/r/55286/#review52048

lgtm.
Attachment #8756627 - Flags: review?(erahm) → review+
Comment on attachment 8756628 [details]
Bug 1275744 - Reference MOZ_LOG in xpconnect comments.

https://reviewboard.mozilla.org/r/55288/#review52050

lgtm.

::: js/xpconnect/src/XPCLog.h:15
(Diff revision 1)
>  #define xpclog_h___
>  
>  #include "mozilla/Logging.h"
>  
>  /*
>   * This uses prlog.h See prlog.h for environment settings for output.

If you're feeling particularly adeventures we could swap out `prlog.h` for `mozilla/logging.h`.
Attachment #8756628 - Flags: review?(erahm) → review+
(In reply to Eric Rahm [:erahm] (Out until June 6th) from comment #8)

> If you're feeling particularly adeventures we could swap out `prlog.h` for
> `mozilla/logging.h`.

Oops, thanks! I'll update the patch.
NSPR_LOG_MODULES is deprecated.

Review commit: https://reviewboard.mozilla.org/r/55484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55484/
Attachment #8756625 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in leak_gauge. r?dbaron → MozReview Request: Bug 1275744 - Reference MOZ_LOG in leak_gauge. r=dbaron
Attachment #8756626 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in xpcom comments. r?erahm → MozReview Request: Bug 1275744 - Reference MOZ_LOG in xpcom comments. r=erahm
Attachment #8756627 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in netwerk comments. r?erahm → MozReview Request: Bug 1275744 - Reference MOZ_LOG in netwerk comments. r=erahm
Attachment #8756959 - Flags: review?(erahm)
Attachment #8756960 - Flags: review?(erahm)
Attachment #8756961 - Flags: review?(erahm)
Attachment #8756962 - Flags: review?(erahm)
Attachment #8756963 - Flags: review?(erahm)
Attachment #8756964 - Flags: review?(erahm)
Attachment #8756965 - Flags: review?(erahm)
Comment on attachment 8756625 [details]
Bug 1275744 - Reference MOZ_LOG in leak_gauge.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55282/diff/1-2/
Comment on attachment 8756626 [details]
Bug 1275744 - Reference MOZ_LOG in xpcom comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55284/diff/1-2/
Comment on attachment 8756627 [details]
Bug 1275744 - Reference MOZ_LOG in netwerk comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55286/diff/1-2/
Comment on attachment 8756628 [details]
Bug 1275744 - Reference MOZ_LOG in xpconnect comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55288/diff/1-2/
Attachment #8756959 - Flags: review?(erahm) → review+
Comment on attachment 8756959 [details]
Bug 1275744 - Reference MOZ_LOG in dom comments.

https://reviewboard.mozilla.org/r/55484/#review54878

::: dom/media/systemservices/OpenSLESProvider.cpp:14
(Diff revision 1)
>  
>  #include <dlfcn.h>
>  #include <SLES/OpenSLES_Android.h>
>  #include <SLES/OpenSLES_AndroidConfiguration.h>
>  
> -// NSPR_LOG_MODULES=OpenSLESProvider:5
> +// MOZ_LOG_MODULES=OpenSLESProvider:5

\- '\_MODULES'
Comment on attachment 8756960 [details]
Bug 1275744 - Reference MOZ_LOG in toolkit comments.

https://reviewboard.mozilla.org/r/55486/#review54884
Attachment #8756960 - Flags: review?(erahm) → review+
Comment on attachment 8756961 [details]
Bug 1275744 - Reference MOZ_LOG in windows widget comments.

https://reviewboard.mozilla.org/r/55488/#review54886

::: widget/windows/nsdefs.h:23
(Diff revision 1)
>    #define VERIFY(exp)                 if (!(exp)) { GetLastError(); BREAK_TO_DEBUGGER; }
>  #else   // !_DEBUG
>    #define VERIFY(exp)                 (exp)
>  #endif  // !_DEBUG
>  
>  // NSPR Win32 modules:

Can we get rid of this NSRP reference as well?
Attachment #8756961 - Flags: review?(erahm) → review+
Attachment #8756962 - Flags: review?(erahm) → review+
Attachment #8756963 - Flags: review?(erahm) → review+
Comment on attachment 8756964 [details]
Bug 1275744 - Reference MOZ_LOG in graphics comments.

https://reviewboard.mozilla.org/r/55494/#review54896
Attachment #8756964 - Flags: review?(erahm) → review+
Comment on attachment 8756965 [details]
Bug 1275744 - Reference MOZ_LOG in uriloader comments.

https://reviewboard.mozilla.org/r/55496/#review54900

::: uriloader/base/nsDocLoader.cpp:45
(Diff revision 1)
>  static NS_DEFINE_CID(kThisImplCID, NS_THIS_DOCLOADER_IMPL_CID);
>  
>  //
>  // Log module for nsIDocumentLoader logging...
>  //
>  // To enable logging (see prlog.h for full details):

`mozilla/Logging.h`

::: uriloader/base/nsDocLoader.cpp:48
(Diff revision 1)
>  // Log module for nsIDocumentLoader logging...
>  //
>  // To enable logging (see prlog.h for full details):
>  //
> -//    set NSPR_LOG_MODULES=DocLoader:5
> -//    set NSPR_LOG_FILE=nspr.log
> +//    set MOZ_LOG=DocLoader:5
> +//    set MOZ_LOG_FILE=nspr.log

Remove nspr reference.
Attachment #8756965 - Flags: review?(erahm) → review+
Thanks for catching those. I've updated the patches to include your comments. Carrying forward r+.
Comment on attachment 8756625 [details]
Bug 1275744 - Reference MOZ_LOG in leak_gauge.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55282/diff/2-3/
Attachment #8756625 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in leak_gauge. r=dbaron → Bug 1275744 - Reference MOZ_LOG in leak_gauge.
Attachment #8756626 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in xpcom comments. r=erahm → Bug 1275744 - Reference MOZ_LOG in xpcom comments.
Attachment #8756627 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in netwerk comments. r=erahm → Bug 1275744 - Reference MOZ_LOG in netwerk comments.
Attachment #8756628 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in xpconnect comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in xpconnect comments.
Attachment #8756959 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in dom comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in dom comments.
Attachment #8756960 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in toolkit comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in toolkit comments.
Attachment #8756961 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in windows widget comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in windows widget comments.
Attachment #8756962 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in layout comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in layout comments.
Attachment #8756963 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in rdf comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in rdf comments.
Attachment #8756964 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in graphics comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in graphics comments.
Attachment #8756965 - Attachment description: MozReview Request: Bug 1275744 - Reference MOZ_LOG in uriloader comments. r?erahm → Bug 1275744 - Reference MOZ_LOG in uriloader comments.
Comment on attachment 8756626 [details]
Bug 1275744 - Reference MOZ_LOG in xpcom comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55284/diff/2-3/
Comment on attachment 8756627 [details]
Bug 1275744 - Reference MOZ_LOG in netwerk comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55286/diff/2-3/
Comment on attachment 8756628 [details]
Bug 1275744 - Reference MOZ_LOG in xpconnect comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55288/diff/2-3/
Comment on attachment 8756959 [details]
Bug 1275744 - Reference MOZ_LOG in dom comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55484/diff/1-2/
Comment on attachment 8756960 [details]
Bug 1275744 - Reference MOZ_LOG in toolkit comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55486/diff/1-2/
Comment on attachment 8756961 [details]
Bug 1275744 - Reference MOZ_LOG in windows widget comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55488/diff/1-2/
Comment on attachment 8756962 [details]
Bug 1275744 - Reference MOZ_LOG in layout comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55490/diff/1-2/
Comment on attachment 8756963 [details]
Bug 1275744 - Reference MOZ_LOG in rdf comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55492/diff/1-2/
Comment on attachment 8756964 [details]
Bug 1275744 - Reference MOZ_LOG in graphics comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55494/diff/1-2/
Comment on attachment 8756965 [details]
Bug 1275744 - Reference MOZ_LOG in uriloader comments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55496/diff/1-2/
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4051f37e7811
Reference MOZ_LOG in leak_gauge. r=dbaron
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d9559bf89f7
Reference MOZ_LOG in xpcom comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/3939e0bdda15
Reference MOZ_LOG in netwerk comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/c911359b0f25
Reference MOZ_LOG in xpconnect comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd70b49846ff
Reference MOZ_LOG in dom comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/120bf5679c2f
Reference MOZ_LOG in toolkit comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f8df48ff0df
Reference MOZ_LOG in windows widget comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/38bb1806efe1
Reference MOZ_LOG in layout comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/49ddea0a2919
Reference MOZ_LOG in rdf comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/95c27c345545
Reference MOZ_LOG in graphics comments. r=erahm
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c27bbcba434
Reference MOZ_LOG in uriloader comments. r=erahm
You need to log in before you can comment on or make changes to this bug.