Closed Bug 1275750 Opened 3 years ago Closed 3 years ago

Remove some dead code in imgFrame

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: seth, Assigned: seth)

Details

Attachments

(3 files)

There is some dead code laying around in imgFrame. Let's get rid of it.
ScalingData isn't used anywhere, because the old HQ scaling code has been
completely removed and replaced with downscale-during-decode.
Attachment #8756612 - Flags: review?(edwin)
GetDrawTarget() isn't used anywhere; VectorImage used to use it, but it now uses
imgFrame::InitWithDrawable(). GetStride() can also be removed since only
GetDrawTarget() uses it.
Attachment #8756613 - Flags: review?(edwin)
Nothing uses GetFormat().
Attachment #8756614 - Flags: review?(edwin)
Comment on attachment 8756612 [details] [diff] [review]
(Part 1) - Remove unused ScalingData-related code.

Review of attachment 8756612 [details] [diff] [review]:
-----------------------------------------------------------------

yay
Attachment #8756612 - Flags: review?(edwin) → review+
Comment on attachment 8756613 [details] [diff] [review]
(Part 2) - Remove unused GetDrawTarget()-related code.

Review of attachment 8756613 [details] [diff] [review]:
-----------------------------------------------------------------

woo
Attachment #8756613 - Flags: review?(edwin) → review+
Comment on attachment 8756614 [details] [diff] [review]
(Part 3) - Remove imgFrame::GetFormat().

Review of attachment 8756614 [details] [diff] [review]:
-----------------------------------------------------------------

<3 removing code
Attachment #8756614 - Flags: review?(edwin) → review+
Thanks for the reviews, Edwin!
You need to log in before you can comment on or make changes to this bug.