Remove some dead code in imgFrame

RESOLVED FIXED in Firefox 49

Status

()

Core
ImageLib
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
There is some dead code laying around in imgFrame. Let's get rid of it.
(Assignee)

Comment 1

2 years ago
Created attachment 8756612 [details] [diff] [review]
(Part 1) - Remove unused ScalingData-related code.

ScalingData isn't used anywhere, because the old HQ scaling code has been
completely removed and replaced with downscale-during-decode.
Attachment #8756612 - Flags: review?(edwin)
(Assignee)

Comment 2

2 years ago
Created attachment 8756613 [details] [diff] [review]
(Part 2) - Remove unused GetDrawTarget()-related code.

GetDrawTarget() isn't used anywhere; VectorImage used to use it, but it now uses
imgFrame::InitWithDrawable(). GetStride() can also be removed since only
GetDrawTarget() uses it.
Attachment #8756613 - Flags: review?(edwin)
(Assignee)

Comment 3

2 years ago
Created attachment 8756614 [details] [diff] [review]
(Part 3) - Remove imgFrame::GetFormat().

Nothing uses GetFormat().
Attachment #8756614 - Flags: review?(edwin)
Comment on attachment 8756612 [details] [diff] [review]
(Part 1) - Remove unused ScalingData-related code.

Review of attachment 8756612 [details] [diff] [review]:
-----------------------------------------------------------------

yay
Attachment #8756612 - Flags: review?(edwin) → review+
Comment on attachment 8756613 [details] [diff] [review]
(Part 2) - Remove unused GetDrawTarget()-related code.

Review of attachment 8756613 [details] [diff] [review]:
-----------------------------------------------------------------

woo
Attachment #8756613 - Flags: review?(edwin) → review+
Comment on attachment 8756614 [details] [diff] [review]
(Part 3) - Remove imgFrame::GetFormat().

Review of attachment 8756614 [details] [diff] [review]:
-----------------------------------------------------------------

<3 removing code
Attachment #8756614 - Flags: review?(edwin) → review+
(Assignee)

Comment 7

2 years ago
Thanks for the reviews, Edwin!

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/09070d5abf9f
https://hg.mozilla.org/mozilla-central/rev/7c4ec7324278
https://hg.mozilla.org/mozilla-central/rev/945c510ffa9b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.