Closed Bug 1275784 Opened 4 years ago Closed 4 years ago

Enable reader view bookmark hint up to beta

Categories

(Firefox for Android :: Reader View, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox49 --- affected
fennec 49+ ---
firefox50 --- affected
firefox51 --- affected

People

(Reporter: ahunt, Assigned: Margaret)

References

(Blocks 1 open bug, )

Details

Attachments

(3 files)

We currently have an experiment where we show a prompt the first time reader-view is used (Bug 1270880).

What do we want to do with this? We could enable this prompt for everyone (however we might want to disable the prompt that is shown when bookmarking an RV page for the first time, since you could potentially have both prompts shown, one after another).

(Note: this was originally broken, the experiment is therefore effectively enabled as of yesterday.)
Barbara: what are your opinions? Note we don't have any data on this yet because the experiment was broken, data should start arriving soon.
Flags: needinfo?(bbermes)
tracking-fennec: --- → ?
Assignee: nobody → ahunt
tracking-fennec: ? → 49+
I suggest to enable it only for the ones that don't have the other prompt shown.
Flags: needinfo?(bbermes)
Blocks: migrate-RL
Let's make this have its own Aha card, and track 49.
Flags: needinfo?(bbermes)
I chatted with Barbara, let's stick with the current logic to always show this prompt the first time a user enters reader view, regardless of whether we've shown the other prompt.

Let's enable this for all users up to beta, and monitor for feedback there.

ahunt, if we change the switchboard config to enable this for all users up to beta, will a buggy version be enabled on 48, or is the bug that it just won't appear? I want to understand what we should expect here.
Flags: needinfo?(ahunt)
Summary: FIrst time reader view prompt evaluation → Enable reader view bookmark hint up to beta
Assignee: ahunt → margaret.leibovic
Flags: needinfo?(ahunt)
Attachment #8764339 - Flags: review?(s.kaspari)
Comment on attachment 8764339 [details] [review]
Enable reader view bookmark hint up to beta. r=sebastian

triple r+
Attachment #8764339 - Flags: review?(s.kaspari) → review+
ahunt, looking at code comments, it seems like we do either only show this prompt, or the prompt when a user first bookmarks a reader view item:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/promotion/ReaderViewBookmarkPromotion.java#78

There has been so much confusion around the behavior of these two prompts, and I'm finding the miscommunication frustrating. Can you be sure to clearly document how these two prompts interact with each other, and how they interact with this switchboard experiment?
Flags: needinfo?(ahunt)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I've filed Bug 1282908 to sort out the documentation regarding these prompts - I'm not entirely sure where the best place for that is though: given that we have various switchboard experiments and telemetry, documenting all the interactions might want to live somewhere that's more accessible than the source code.
Flags: needinfo?(ahunt)
Attached image screenshot-prompt.png
Tapping the reader view icon, the prompt is displayed. But the page does not enter reader view, it remains in normal view., with the reader view icon in the URL Bar. Tapping "Add to bookmarks" will add the page to bookmarks. Shouldn't the page be in reader view?
The page should be in reader view, as the prompt says: "bookmark reader view items"
(In reply to Teodora Vermesan (:TeoVermesan) from comment #9)
> Tapping the reader view icon, the prompt is displayed. But the page does not
> enter reader view, it remains in normal view., with the reader view icon in
> the URL Bar. Tapping "Add to bookmarks" will add the page to bookmarks.
> Shouldn't the page be in reader view?

Oh, this is weird. Does this happen with just this page or all? Can you file a separate bug for that?
Thanks for the follow up Teo! 
She will be tracking more work on this here: https://wiki.mozilla.org/QA/Fennec/First_time_reader_view_prompt_evaluation
Depends on: 1300532
QA Contact: teodora.vermesan
You need to log in before you can comment on or make changes to this bug.