Closed Bug 1275878 Opened 5 years ago Closed 4 years ago

Replace places-will-close-connection notification with a shutdown blocker

Categories

(Toolkit :: Places, defect, P2)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox49 --- affected
firefox56 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(2 files)

Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.
58 bytes, text/x-review-board-request
adw
: review+
Details
Bug 1275878 - Part 1: move back clear history operations to History.clear().
58 bytes, text/x-review-board-request
adw
: review+
Details 
No description provided.
Review commit: https://reviewboard.mozilla.org/r/56222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56222/
Attachment #8756826 - Attachment description: MozReview Request: Bug 1275878 - Replace places-will-close-connection notification with a shutdown blocker. → MozReview Request: Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=
Comment on attachment 8756826 [details]
Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55438/diff/1-2/
Unfortunately these undiscover a leak in browser_privatebrowsing_placestitle.js, that is unlikely to be related to the changes made here. It's more likely a timing skew in tests execution.
It is also not reproducible locally :(
Blocks: 977053
Priority: -- → P2
Comment on attachment 8757828 [details]
Bug 1275878 - Part 1: move back clear history operations to History.clear().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56222/diff/1-2/
Attachment #8757828 - Attachment description: MozReview Request: Bug 1275878 - Part 1: move back clear history operations to History.clear(). r= → Bug 1275878 - Part 1: move back clear history operations to History.clear(). r=
Attachment #8756826 - Attachment description: MozReview Request: Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r= → Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=
Comment on attachment 8756826 [details]
Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55438/diff/2-3/
Depends on: 1354032
Blocks: 1376533
Blocks: 1382465
Attachment #8757828 - Flags: review?(standard8) → review?(adw)
Attachment #8756826 - Flags: review?(standard8) → review?(adw)
Drew: since I'm going to be away from tomorrow, and didn't have time to look at these today due to some fire fighting with intermittents, I've passed them onto you.
Comment on attachment 8757828 [details]
Bug 1275878 - Part 1: move back clear history operations to History.clear().

https://reviewboard.mozilla.org/r/56222/#review165412

LGTM
Attachment #8757828 - Flags: review?(adw) → review+
Comment on attachment 8756826 [details]
Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.

https://reviewboard.mozilla.org/r/55438/#review165414

LGTM
Attachment #8756826 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/a4ae03c61b15
Part 1: move back clear history operations to History.clear(). r=adw
https://hg.mozilla.org/integration/autoland/rev/b217b97a7478
Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=adw
https://hg.mozilla.org/mozilla-central/rev/a4ae03c61b15
https://hg.mozilla.org/mozilla-central/rev/b217b97a7478
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.