Replace places-will-close-connection notification with a shutdown blocker

RESOLVED FIXED in Firefox 56

Status

()

defect
P2
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 affected, firefox56 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

3 years ago
No description provided.
Assignee

Comment 2

3 years ago
Review commit: https://reviewboard.mozilla.org/r/56222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56222/
Attachment #8756826 - Attachment description: MozReview Request: Bug 1275878 - Replace places-will-close-connection notification with a shutdown blocker. → MozReview Request: Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=
Assignee

Comment 3

3 years ago
Comment on attachment 8756826 [details]
Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55438/diff/1-2/
Assignee

Comment 4

3 years ago
Unfortunately these undiscover a leak in browser_privatebrowsing_placestitle.js, that is unlikely to be related to the changes made here. It's more likely a timing skew in tests execution.
It is also not reproducible locally :(
Assignee

Updated

3 years ago
Blocks: 977053
Priority: -- → P2
Assignee

Comment 5

3 years ago
Comment on attachment 8757828 [details]
Bug 1275878 - Part 1: move back clear history operations to History.clear().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56222/diff/1-2/
Attachment #8757828 - Attachment description: MozReview Request: Bug 1275878 - Part 1: move back clear history operations to History.clear(). r= → Bug 1275878 - Part 1: move back clear history operations to History.clear(). r=
Attachment #8756826 - Attachment description: MozReview Request: Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r= → Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=
Assignee

Comment 6

3 years ago
Comment on attachment 8756826 [details]
Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55438/diff/2-3/
Assignee

Updated

2 years ago
Depends on: 1354032
Assignee

Updated

2 years ago
Blocks: 1376533
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Blocks: 1382465
Attachment #8757828 - Flags: review?(standard8) → review?(adw)
Attachment #8756826 - Flags: review?(standard8) → review?(adw)
Drew: since I'm going to be away from tomorrow, and didn't have time to look at these today due to some fire fighting with intermittents, I've passed them onto you.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

2 years ago
mozreview-review
Comment on attachment 8757828 [details]
Bug 1275878 - Part 1: move back clear history operations to History.clear().

https://reviewboard.mozilla.org/r/56222/#review165412

LGTM
Attachment #8757828 - Flags: review?(adw) → review+

Comment 13

2 years ago
mozreview-review
Comment on attachment 8756826 [details]
Bug 1275878 - Part 2: Replace places-will-close-connection notification with a shutdown blocker.

https://reviewboard.mozilla.org/r/55438/#review165414

LGTM
Attachment #8756826 - Flags: review?(adw) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 16

2 years ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/a4ae03c61b15
Part 1: move back clear history operations to History.clear(). r=adw
https://hg.mozilla.org/integration/autoland/rev/b217b97a7478
Part 2: Replace places-will-close-connection notification with a shutdown blocker. r=adw

Comment 17

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a4ae03c61b15
https://hg.mozilla.org/mozilla-central/rev/b217b97a7478
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.