[TSF] Perhaps, TSFTextStore shouldn't notify TSF of selection change after notifying TSF of text change

RESOLVED FIXED

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod, perf})

Trunk
All
Windows
inputmethod, perf
Points:
---

Firefox Tracking Flags

(firefox49 affected)

Details

I realized that when we notify TSF/TIP of text change, TSF/TIP must always check new selection because keeping believing selection in old contents doesn't make sense.

So, I think that TSFTextStore should check if selection is retrieved by TSF/TIP during notifying TSF/TIP of a text change, we shouldn't notify TSF/TIP of selection change.

This must reduce a lot of WidgetQueryContentEvent cost.
OS: All → Windows
The fix of bug 1224994 makes it this behavior unexpectedly.

However, at least for Google Japanese Input, looks like it has trouble. Anyway, I'll investigate it on other bug.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Depends on: 1224994
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.