Closed Bug 1275918 Opened 3 years ago Closed 3 years ago

[e10s] ContentCacheInParent doesn't update mCompositionStart

Categories

(Core :: User events and focus handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
e10s + ---
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(2 files)

Start offset of composition string can be changed by JS until composition actually puts at least one character into focused editor.

On the other hand, ContentCacheInParent stores mCompositionStart before sending eCompositionStart to remote process with cached selection. So, the value may be outdated at inserting first character of composition string.
tracking-e10s: --- → +
FYI: bug 1275914 makes TextComposition updates mCompositionStartOffset after event dispatch and mTargetClauseOffset value relative offset from mCompositionStartOffset (renamed to mTargetClauseOffsetInComposition).
Comment on attachment 8762520 [details]
Bug 1275918 part.1 ContentCache should retrieve the latest composition start offset from TextComposition and send it to the parent process

https://reviewboard.mozilla.org/r/59168/#review56206
Attachment #8762520 - Flags: review?(m_kato) → review+
Comment on attachment 8762521 [details]
Bug 1275918 part.2 Update TextComposition::mCompositionStartOffset when it's modified in the remote process

https://reviewboard.mozilla.org/r/59170/#review56208

I need fix log output, then r+.

::: widget/ContentCache.cpp:465
(Diff revision 1)
>      ("ContentCacheInParent: 0x%p AssignContent(aNotification=%s), "
>       "Succeeded, mText.Length()=%u, mSelection={ mAnchor=%u, mFocus=%u, "
>       "mWritingMode=%s, mAnchorCharRect=%s, mFocusCharRect=%s, mRect=%s }, "
>       "mFirstCharRect=%s, mCaret={ mOffset=%u, mRect=%s }, mTextRectArray={ "
>       "mStart=%u, mRects.Length()=%u }, mCompositionStart=%u, mEditorRect=%s",
>       this, GetNotificationName(aNotification),

You forget "mIsComposing=%s".
Attachment #8762521 - Flags: review?(m_kato) → review+
Comment on attachment 8762520 [details]
Bug 1275918 part.1 ContentCache should retrieve the latest composition start offset from TextComposition and send it to the parent process

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59168/diff/1-2/
Comment on attachment 8762521 [details]
Bug 1275918 part.2 Update TextComposition::mCompositionStartOffset when it's modified in the remote process

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59170/diff/1-2/
https://reviewboard.mozilla.org/r/59170/#review56208

> You forget "mIsComposing=%s".

Thank you! Enjoy London and Euro 2016 ;-)
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eefc9532e715
part.1 ContentCache should retrieve the latest composition start offset from TextComposition and send it to the parent process r=m_kato
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbe31ff52ae4
part.2 Update TextComposition::mCompositionStartOffset when it's modified in the remote process r=m_kato
https://hg.mozilla.org/mozilla-central/rev/eefc9532e715
https://hg.mozilla.org/mozilla-central/rev/bbe31ff52ae4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.