127592 - [FIX]`PRBool readError' might be used uninitialized (bug 27609 leftovers)

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P1)

Description

[Aleksey Nogin]

Bug 27609 check-ins added two "`PRBool readError' might be used uninitialized"
warnings:

embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp:674
 `PRBool readError' might be used uninitialized in this function

uriloader/exthandler/nsExternalHelperAppService.cpp:1159
 `PRBool readError' might be used uninitialized in this function

Attachment 70686 [details] [diff] on bug 27609 has a fix (and r=hwaara).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: The patch

Comment 2

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 71261 [details] [diff] [review]
The patch

sr=shaver.  This is a nothing patch, I'll waive the requirement for r=.

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 71261 [details] [diff] [review]
The patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 4

[Boris Zbarsky [:bzbarsky]]

checked in on trunk

Comment 5

[Aleksey Nogin]

Warnings went away on TBox, marking verified.

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 71261 [details] [diff] [review]
The patch

noting r=me to make up for my slow sr= request queue processing.

/be