1275934 - Intermittent toolkit/mozapps/extensions/test/xpcshell/test_system_update.js | Test timed out

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer.html#?job_id=9556505&repo=fx-team#L2115

Comment 1

[Robert Helmer [:rhelmer]]

Thanks for filing.

From a quick look at the log, I think this is failing because httpd.js is throwing this during shutdown:

10:21:26     INFO -  PROCESS | 12300 | JavaScript strict warning: resource://testing-common/httpd.js, line 791: ReferenceError: reference to undefined property this._stopCallback
10:21:26     INFO -  PROCESS | 12300 | !!! error running onStopped callback: TypeError: callback is not a function
10:21:26     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property this._stopCallback" {file: "resource://testing-common/httpd.js" line: 791}]"

Then the test runner attempts to kill the process but it's already gone, which leads to the "OSError: [Errno 3] No such process" in the treeherder summary.

In https://dxr.mozilla.org/mozilla-central/rev/8d0aadfe7da782d415363880008b4ca027686137/netwerk/test/httpserver/httpd.js it looks like `this._stopCallback` should be defined in `stop()` so presumably that's not getting called (or not getting called soon enough), https://dxr.mozilla.org/mozilla-central/rev/8d0aadfe7da782d415363880008b4ca027686137/netwerk/test/httpserver/httpd.js#791 checks for `null` but not `undefined` (and it's an assert so also presumably it'd fail the test so it shouldn't be in this state).

Comment 2

[Robert Helmer [:rhelmer]]

OK looked again and comment 1 is a red herring, here's the real error:

10:21:16     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "1464257998535	Toolkit.GMP	ERROR	GMPWrapper(gmp-gmpopenh264) findUpdates() - updateTask for gmp-gmpopenh264 threw: Error: Failed downloading XML, status: 0, reason: error (resource://gre/modules/addons/ProductAddonChecker.jsm:111:16) JS Stack trace: downloadXML/</[e-mail]:111:16 < [e-mail]:209:5 < [e-mail]:533:5 < @-e:1:1 < [e-mail]:299:24 < AddonManagerInternal.backgroundUpdateCheck/buPromise</<@AddonManager.jsm:1456:13 < [e-mail]:388:5 < AddonManagerInternal.backgroundUpdateCheck/buPromise<@AddonManager.jsm:1455:24 < [e-mail]:319:40 < [e-mail]:937:23 < [e-mail]:816:7 < Promise*[e-mail]:747:11 < [e-mail]:779:7 < [e-mail]:714:7 < get _worker/[e-mail]:231:9 < [e-mail]:209:5 < [e-mail]:533:5 < @-e:1:1" {file: "resource://gre/modules/Log.jsm" line: 753}]

comment 1 is happening because shutdown has started due to the above failure.

Comment 3

[BMO Automation]

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Comment 4

[Intermittent Failures Robot]

1 failures in 943 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1275934&startday=2017-09-18&endday=2017-09-24&tree=all

Comment 5

[Robert Helmer [:rhelmer]]

This test no longer exists.. it was split up into several as part of bug 1348981.

I expect this to totally resolve the timeout problems we've had with system add-on update tests.