1275945 - Don't create the AutoJSContext in nsNodeUtils::CloneAndAdopt if we don't have an aReparentScope

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The changes in bug 839467 made CloneAndAdopt always push stuff on the JSContext stack.  This isn't very desirable, both for performance reasons and because it lands a null-compartment thing on the stack.

In practice, we only use this AutoJSContext when aReparentScope is non-null, so we should only construct it in that case.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Move the AutoJSContext use in nsNodeUtils::CloneAndAdopt to where it's really needed

This prevents us from pushing stuff on the JSContext stack unnecessarily when
we're just cloning, not adopting.  It's OK that we're doing it in a narrow scope
that doesn't include our recursion into children, because in practice when
aReparentScope is non-null we came from nsIDocument::AdoptNode which already
does AutoJSContext.  So we're not going to continuously push/pop the JSContext
stack in that situation, since something already got pushed on it.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72ea7eafc5e5

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72ea7eafc5e5