Closed Bug 1275982 Opened 9 years ago Closed 9 years ago

mach buildsymbols should work in parallel

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: mayhemer, Unassigned)

Details

On a fast machine it takes over 5 minutes to complete. And when symbols have to be used after every small change (build binaries takes way less then a minute) it ruins all the parallelism we have elsewhere.
It does run in parallel. xul just takes forever to process. See bug 1275672 for why.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Yes, you are right, I had to look more careful, thanks.
(In reply to Honza Bambas (:mayhemer) from comment #0) > And when symbols have to be used after every small change (build binaries takes way less then > a minute) it ruins all the parallelism we have elsewhere. Why do you need to run it so often? mach buildsymbols is not very useful to developers (why the hell is there even a mach command for it?)
(In reply to Mike Hommey [:glandium] from comment #3) > (In reply to Honza Bambas (:mayhemer) from comment #0) > > And when symbols have to be used after every small change (build binaries takes way less then > > a minute) it ruins all the parallelism we have elsewhere. > > Why do you need to run it so often? mach buildsymbols is not very useful to > developers (why the hell is there even a mach command for it?) Mike, some people are using Gecko Profiler that, to work fully featured, needs symbols to be up to date after every build. That is the reason I run the nice and very useful mach command every time I change just even only one line that links to libxul. I currently build a new feature for Gecko Profiler, so I need symbols be up to date quite often.
Running mach buildsymbols should not be needed for the Gecko Profiler for local builds. If it is, please file a bug with more specifics.
(come to think of it, I see how you can need to, if you're on mac, in which case, you don't need buildsymbols, you need a smaller part of it, which doesn't have a command, and that would be a bug to file too)
And there is probably another bug to file against the gecko profiler to be smarter about dSYMs. AFAIK, gdb/lldb doesn't need them to be linked (which is what you're using mach buildsymbols for), so the profiler can probably do something.
I'm on Windows. I think I need to repack PDBs every time a change is made because the debug ID that links the executables with PDBs is changed. Hence the final zip needs update every time IMO, and mainly xul, which I change mostly, of course. Will do more testing here tho and let you know. Thanks!
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.