1275983 - Add relations caching tests.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Continuing e10s compatible tests effort: adding state caching tests inspired by https://dxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/relations/test_update.html

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1275983 cpp patch

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1275983 tests

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 8757396 [details] [diff] [review]
1275983 tests

Review of attachment 8757396 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8757395 [details] [diff] [review]
1275983 cpp patch

>Bug 1275983 - adding proxy support in GetRelationByType for xpcom. r=tbsaunde

support proxies in xpcAccessible::GetRelationByType() or something.  At least it should be add not adding, and the english is kind of wierd.

>+nsAccessibleRelation::nsAccessibleRelation(uint32_t aType,
>+                                           nsTArray<ProxyAccessible*>* aTargets) :

make it const

>+  mType(aType)
>+{
>+  mTargets = do_CreateInstance(NS_ARRAY_CONTRACTID);
>+  for (uint32_t idx = 0; idx < aTargets->Length(); ++idx) {
>+    mTargets->AppendElement(
>+      static_cast<nsIAccessible*>(ToXPC(aTargets->ElementAt(idx))),

I don't see why you need the cast, and given the length a local var would be good though maybe removing the cast fixes that.

>-  Relation rel = Intl()->RelationByType(static_cast<RelationType>(aType));
>-  NS_ADDREF(*aRelation = new nsAccessibleRelation(aType, &rel));
>+  if (IntlGeneric().IsAccessible()) {
>+    Relation rel = Intl()->RelationByType(static_cast<RelationType>(aType));
>+    NS_ADDREF(*aRelation = new nsAccessibleRelation(aType, &rel));
>+    return *aRelation ? NS_OK : NS_ERROR_FAILURE;

*aRelation is always true so you might as well drop the condition

>+  NS_ADDREF(*aRelation = new nsAccessibleRelation(aType, &targets));
>+
>   return *aRelation ? NS_OK : NS_ERROR_FAILURE;

same

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e88388524a5f

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e80d6ebb0f9
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfa30f88a5e5

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e80d6ebb0f9
https://hg.mozilla.org/mozilla-central/rev/dfa30f88a5e5