Closed Bug 1275998 Opened 4 years ago Closed 4 years ago

L10n repacks use compressed omni.ja even if en-US don't

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox49 affected, firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox49 --- affected
firefox50 --- fixed

People

(Reporter: catlee, Assigned: catlee)

References

Details

Attachments

(1 file)

In bug 1231379 I disabled compression for omni.ja on nighlyt, which ends up reducing installer and update sizes.

I just discovered that this doesn't work for l10n repacks because a different codepath is used to package omni.ja files there.
Depends on: 1231379
Assignee: nobody → catlee
Comment on attachment 8756956 [details]
Bug 1275998 - L10n repacks should use the same compression settings for omni.ja as en-US

https://reviewboard.mozilla.org/r/55482/#review52342

r+ with the following fixed.

::: python/mozbuild/mozpack/mozjar.py:408
(Diff revision 1)
> +    def is_compressed(self):
> +        '''
> +        Return whether the jar archive is compressed.
> +        '''
> +        return any(f.compressed for f in self)

I'd rather not add this method, and just use any(f.compressed for f in jar) in UnpackFinder._open_jar.

::: python/mozbuild/mozpack/packager/l10n.py:240
(Diff revision 1)
>          l10n_finder = ComposedFinder(finders)
>      copier = FileCopier()
>      if app_finder.kind == 'flat':
>          formatter = FlatFormatter(copier)
>      elif app_finder.kind == 'jar':
>          formatter = JarFormatter(copier, optimize=app_finder.optimizedjars)

You should add the compressed argument here too.
Attachment #8756956 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8756956 [details]
Bug 1275998 - L10n repacks should use the same compression settings for omni.ja as en-US

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/55482/diff/1-2/
Attachment #8756956 - Attachment description: MozReview Request: Bug 1275998: L10n repacks should use the same compression settings for omni.ja as en-US r=glandium → Bug 1275998 - L10n repacks should use the same compression settings for omni.ja as en-US
Pushed by catlee@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c039c5822c2
L10n repacks should use the same compression settings for omni.ja as en-US r=glandium
https://hg.mozilla.org/mozilla-central/rev/2c039c5822c2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.