1276014 - tc-client no longer throws on 404's

Status: RESOLVED INVALID

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

$ cat t.js 
var taskcluster = require('taskcluster-client');
var sched = new taskcluster.Scheduler({});
sched.inspect('AdZWLeodSMSeuJxgClQ0Bg').then(function(res) { console.log("ok (UHOH!)", res); }).catch(function(err) { console.log("err (expected)", err); })

taskcluster-client@0.21.3:

$ node t.js 
err (expected) { [Error: task-graph not found!] body: { message: 'task-graph not found!' }, statusCode: 404 }

taskcluster-client@1.0.1:

$ node t.js 
ok (UHOH!) { message: 'task-graph not found!' }

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

OK, this is actually an npm bug (aren't they all?)

taskcluster-client is installed with superagent-1.7.2, but npm resolves it to superagent-0.21.0:

mozilla-taskcluster@1.0.0 /home/dustin/p/mozilla-taskcluster
├─┬ mozilla-treeherder@0.7.0
│ └── superagent@0.16.0 
├── superagent@0.21.0  (git://github.com/visionmedia/superagent.git#e6c302c2e83cbf76182ea10b6a1ef6fd0d4e0b2b)
└─┬ taskcluster-client@1.0.1
  └── superagent@1.7.2 

Nix is looking *really* appealing these days.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Still we should get rid of superagent here...
The reason this happens is that tc-client includes superagent-promise which includes the wrong superagent because it has the same version between the two...

So peerDeps is sort of part of the problem here...

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Would this have been better were mozilla-taskcluster using node-4 or higher?