1276022 - Stopping or interrupting dev environment leaves broken environment, requires manual cleanup

Status: RESOLVED INVALID

(MozReview Graveyard :: Testing / Development Environment, defect)

Description

[Māris Fogels [:mars] (please needinfo)]

Interrupting the container build process in 'mozreview start', either with ^C or a build script error, causes following calls to 'mozreview start' to fail with an error.  This leaves the dev environment built by start-local-mozreview in a broken, half-built state with no running containers.

Removing the ../mozreview-test directory will get start-local-mozreview and 'mozreview start' to work again, but it requires a full dev environment rebuild.


Traceback follows:

--- begin start-local-mozreview log ---

treestatus> Successfully built ba264ac1b8b0
Error running mach:

    ['start', '--reviewboard-port=55556', '/home/vagrant/mozreview-test']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

RuntimeError: Container '9bd586f10ff18357fab3cd0d2b2b5b177ed9371fcf975a0b3303a279cef37357' should have been started by the calling function, but is not running

  File "/home/vagrant/mozreview/testing/vcttesting/mozreview_mach_commands.py", line 77, in start
    verbose=True)
  File "/home/vagrant/mozreview/testing/vcttesting/mozreview.py", line 214, in start
    verbose=verbose)
  File "/home/vagrant/mozreview/testing/vcttesting/docker.py", line 963, in start_mozreview
    images = self.build_mozreview(verbose=verbose)
  File "/home/vagrant/mozreview/testing/vcttesting/docker.py", line 789, in build_mozreview
    images.update(f_images.result())
  File "/home/vagrant/mozreview/venv/local/lib/python2.7/site-packages/concurrent/futures/_base.py", line 398, in result
    return self.__get_result()
  File "/home/vagrant/mozreview/venv/local/lib/python2.7/site-packages/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/vagrant/mozreview/testing/vcttesting/docker.py", line 602, in ensure_images_built
    name, image = f.result()
  File "/home/vagrant/mozreview/venv/local/lib/python2.7/site-packages/concurrent/futures/_base.py", line 398, in result
    return self.__get_result()
  File "/home/vagrant/mozreview/venv/local/lib/python2.7/site-packages/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/vagrant/mozreview/testing/vcttesting/docker.py", line 561, in build_ansible
    verbose=verbose)
  File "/home/vagrant/mozreview/testing/vcttesting/docker.py", line 666, in run_ansible
    with self.vct_container(image=vct_image, cid=vct_cid, verbose=verbose) as vct_state:
  File "/usr/lib/python2.7/contextlib.py", line 17, in __enter__
    return self.gen.next()
  File "/home/vagrant/mozreview/testing/vcttesting/docker.py", line 1498, in vct_container
    "function, but is not running" % cid)

--- end log ---

Comment 1

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.