Closed Bug 1276093 Opened 3 years ago Closed 3 years ago

Warn on slow format conversions

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

It's not always obvious when an upload call incurs a slow format conversion.

We should warn when this happens.


Eventually, we should warn when we miss a GPU->GPU fast path, but we only support that for video right now.
From 7778749a5a7a25e5e51dd70911a755a28e478db5 Mon Sep 17 00:00:00 2001
---
 dom/canvas/TexUnpackBlob.cpp         | 19 +++++++++++++++----
 dom/canvas/TexUnpackBlob.h           |  2 +-
 dom/canvas/WebGLTexelConversions.cpp |  7 ++++++-
 dom/canvas/WebGLTexelConversions.h   |  3 ++-
 4 files changed, 24 insertions(+), 7 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/55594/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55594/
Attachment #8757077 - Flags: review?(jmuizelaar)
Attachment #8757078 - Flags: review?(jmuizelaar)
From cbd47e62b513fe53a4e4b82c46c253578c1e9808 Mon Sep 17 00:00:00 2001
---
 dom/canvas/TexUnpackBlob.cpp | 4 ++++
 1 file changed, 4 insertions(+)

Review commit: https://reviewboard.mozilla.org/r/55596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55596/
Attachment #8757077 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8757077 [details]
MozReview Request: Bug 1276093 - r?jrmuizel - Warn on slow CPU format conversions.

https://reviewboard.mozilla.org/r/55594/#review52544

This code would be much better if it returned a Maybe<ConvertedBuffer> where ConvertedBuffer was a struct that contained all of the appropriate information. Can you do this in a follow up?
Attachment #8757078 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8757078 [details]
MozReview Request:  r?jrmuizel - Warn when we fail to hit the GPU-copy fast-path.

https://reviewboard.mozilla.org/r/55596/#review52546
Blocks: 1277125
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2fc488c389f
Warn on slow CPU format conversions. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/d85f0530eb80
Warn when we fail to hit the GPU-copy fast-path. - r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/c2fc488c389f
https://hg.mozilla.org/mozilla-central/rev/d85f0530eb80
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.