1276096 - Crash in conformance2/renderbuffers/readbuffer.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We should at least not crash.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE readbuffer

From 1c8a9fab2d269d71565a4c38cec50e018064f2a2 Mon Sep 17 00:00:00 2001
 mode.
---
 gfx/angle/src/libANGLE/Framebuffer.cpp | 3 +++
 1 file changed, 3 insertions(+)

Review commit: https://reviewboard.mozilla.org/r/55638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55638/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: r?jrmuizel - Introspect for readBuffer mode.

From b738f888177b57a95ace4129f856e9c0c6d4d843 Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGL2ContextState.cpp | 7 ++-----
 dom/canvas/WebGLFramebuffer.h     | 2 ++
 2 files changed, 4 insertions(+), 5 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/55640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55640/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: r?jrmuizel - Forbid reads from backbuffer with readBuffer(NONE).

From f833677175112cbfa2957a8a0ab3c8432c767c63 Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContext.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

Review commit: https://reviewboard.mozilla.org/r/55642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55642/

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: r?jrmuizel - Use existing can-I-read-from-this helper.

From de1398f53d90e508367de67e5f4e024a1e41134f Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContextState.cpp | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/55644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55644/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8757093 [details]
MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE readbuffer

https://reviewboard.mozilla.org/r/55638/#review53200

::: gfx/angle/src/libANGLE/Framebuffer.cpp:72
(Diff revision 1)
>      return mLabel;
>  }
>  
>  const FramebufferAttachment *Framebuffer::Data::getReadAttachment() const
>  {
> +    if (mReadBufferState == GL_NONE)

Has this been upstreamed?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8757095 [details]
MozReview Request:  r?jrmuizel - Forbid reads from backbuffer with readBuffer(NONE).

https://reviewboard.mozilla.org/r/55642/#review53202

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8757094 [details]
MozReview Request:  r?jrmuizel - Introspect for readBuffer mode.

https://reviewboard.mozilla.org/r/55640/#review53204

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8757096 [details]
MozReview Request:  r?jrmuizel - Use existing can-I-read-from-this helper.

https://reviewboard.mozilla.org/r/55644/#review53206

Comment 9

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8757093 [details]
> MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE
> readbuffer
> 
> https://reviewboard.mozilla.org/r/55638/#review53200
> 
> ::: gfx/angle/src/libANGLE/Framebuffer.cpp:72
> (Diff revision 1)
> >      return mLabel;
> >  }
> >  
> >  const FramebufferAttachment *Framebuffer::Data::getReadAttachment() const
> >  {
> > +    if (mReadBufferState == GL_NONE)
> 
> Has this been upstreamed?

No, but I've filed an issue: https://bugs.chromium.org/p/angleproject/issues/detail?id=1400

Comment 10

[Kelsey Gilbert [:jgilbert]]

https://reviewboard.mozilla.org/r/55638/#review53200

> Has this been upstreamed?

Yes: https://bugs.chromium.org/p/angleproject/issues/detail?id=1400

Comment 11

[Kelsey Gilbert [:jgilbert]]

https://reviewboard.mozilla.org/r/55638/#review53200

> Yes: https://bugs.chromium.org/p/angleproject/issues/detail?id=1400

Rather, it's been filed.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8757093 [details]
MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE readbuffer

https://reviewboard.mozilla.org/r/55638/#review53362

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8efba00e40e4
ANGLE should check for NONE readbuffer. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/a84971878829
Introspect for readBuffer mode. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/7606a20b0d3f
Forbid reads from backbuffer with readBuffer(NONE). - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/f999cbf7c7d0
Use existing can-I-read-from-this helper. - r=jrmuizel

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8efba00e40e4
https://hg.mozilla.org/mozilla-central/rev/a84971878829
https://hg.mozilla.org/mozilla-central/rev/7606a20b0d3f
https://hg.mozilla.org/mozilla-central/rev/f999cbf7c7d0