Closed Bug 1276096 Opened 4 years ago Closed 4 years ago

Crash in conformance2/renderbuffers/readbuffer.html

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(4 files)

We should at least not crash.
From 1c8a9fab2d269d71565a4c38cec50e018064f2a2 Mon Sep 17 00:00:00 2001
 mode.
---
 gfx/angle/src/libANGLE/Framebuffer.cpp | 3 +++
 1 file changed, 3 insertions(+)

Review commit: https://reviewboard.mozilla.org/r/55638/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55638/
Attachment #8757093 - Flags: review?(jmuizelaar)
Attachment #8757094 - Flags: review?(jmuizelaar)
Attachment #8757095 - Flags: review?(jmuizelaar)
Attachment #8757096 - Flags: review?(jmuizelaar)
From b738f888177b57a95ace4129f856e9c0c6d4d843 Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGL2ContextState.cpp | 7 ++-----
 dom/canvas/WebGLFramebuffer.h     | 2 ++
 2 files changed, 4 insertions(+), 5 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/55640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55640/
From f833677175112cbfa2957a8a0ab3c8432c767c63 Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContext.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

Review commit: https://reviewboard.mozilla.org/r/55642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55642/
From de1398f53d90e508367de67e5f4e024a1e41134f Mon Sep 17 00:00:00 2001
---
 dom/canvas/WebGLContextState.cpp | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/55644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55644/
Comment on attachment 8757093 [details]
MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE readbuffer

https://reviewboard.mozilla.org/r/55638/#review53200

::: gfx/angle/src/libANGLE/Framebuffer.cpp:72
(Diff revision 1)
>      return mLabel;
>  }
>  
>  const FramebufferAttachment *Framebuffer::Data::getReadAttachment() const
>  {
> +    if (mReadBufferState == GL_NONE)

Has this been upstreamed?
Attachment #8757093 - Flags: review?(jmuizelaar)
Comment on attachment 8757095 [details]
MozReview Request:  r?jrmuizel - Forbid reads from backbuffer with readBuffer(NONE).

https://reviewboard.mozilla.org/r/55642/#review53202
Attachment #8757095 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8757094 [details]
MozReview Request:  r?jrmuizel - Introspect for readBuffer mode.

https://reviewboard.mozilla.org/r/55640/#review53204
Attachment #8757094 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8757096 [details]
MozReview Request:  r?jrmuizel - Use existing can-I-read-from-this helper.

https://reviewboard.mozilla.org/r/55644/#review53206
Attachment #8757096 - Flags: review?(jmuizelaar) → review+
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8757093 [details]
> MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE
> readbuffer
> 
> https://reviewboard.mozilla.org/r/55638/#review53200
> 
> ::: gfx/angle/src/libANGLE/Framebuffer.cpp:72
> (Diff revision 1)
> >      return mLabel;
> >  }
> >  
> >  const FramebufferAttachment *Framebuffer::Data::getReadAttachment() const
> >  {
> > +    if (mReadBufferState == GL_NONE)
> 
> Has this been upstreamed?

No, but I've filed an issue: https://bugs.chromium.org/p/angleproject/issues/detail?id=1400
Attachment #8757093 - Flags: review?(jmuizelaar)
Comment on attachment 8757093 [details]
MozReview Request: Bug 1276096 - r?jrmuizel - ANGLE should check for NONE readbuffer

https://reviewboard.mozilla.org/r/55638/#review53362
Attachment #8757093 - Flags: review?(jmuizelaar) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8efba00e40e4
ANGLE should check for NONE readbuffer. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/a84971878829
Introspect for readBuffer mode. - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/7606a20b0d3f
Forbid reads from backbuffer with readBuffer(NONE). - r=jrmuizel
https://hg.mozilla.org/integration/mozilla-inbound/rev/f999cbf7c7d0
Use existing can-I-read-from-this helper. - r=jrmuizel
You need to log in before you can comment on or make changes to this bug.