1276162 - Make frame iterators view frames from all JSContexts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Frame iterators have a ContextOption that specifies whether they should skip activations belonging to unrelated contexts. The default is CURRENT_CONTEXT.

The saved frame audit (bug 1274193, bug 1274915) converted the most interesting iterators to do principal checking + ALL_CONTEXTS, and I think most places that didn't care about seeing through saved frames also don't care about different contexts.

Comment 1

[Jan de Mooij [:jandem]]

The first patch in bug 979730 is very useful here because the frame iterators it touches are exactly the ones we have to check.

I think all of them are fine with ALL_CONTEXTS, the only one I'm not sure about is GetScriptedCallerGlobal (and the cx skipping we do in GetScriptedCallerActivationFast). I can do a Try push to see if that uncovers anything obvious.

There's also cx->currentScript() where we skip unrelated contexts, but we can deal with that in a separate bug.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Part 1 - Stop skipping contexts in GetScriptedCallerActivationFast

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Part 2 - Remove ContextOption

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8757315 [details] [diff] [review]
Part 1 - Stop skipping contexts in GetScriptedCallerActivationFast

r=me

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8757316 [details] [diff] [review]
Part 2 - Remove ContextOption

Review of attachment 8757316 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

::: js/src/vm/Debugger.cpp
@@ +7013,1 @@
>                                ScriptFrameIter::IGNORE_DEBUGGER_EVAL_PREV_LINK); \

Maybe fold onto one line (since it goes past the macro \ column anyway).

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d04a27a81ae9
https://hg.mozilla.org/integration/mozilla-inbound/rev/54abdc6d524e

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d04a27a81ae9
https://hg.mozilla.org/mozilla-central/rev/54abdc6d524e