1276180 - refactor block layout debug flags in nsBlockDebugFlags.h

Status: NEW

(Core :: Layout, defect)

Description

[Jeremy Chen ([e-mail])]

At present, these flags can only be enabled by defining them manually and then recompile the codes. I think it could be better by refactoring all these flags in the form of what we did for GECKO_BLOCK_DEBUG_FLAGS [1]. These may gain us few advantages:

1. Get these flags and codes under protection of automatic tests (DEBUG build)
2. We can turn on/off these flags at runtime by exporting environment variables
3. During this refactoring, maybe some of the existing flags could be integrated as well. (ex. REALLY_NOISY_REFLOW and nsBlockFrame::gReallyNoisyReflow)


[1] https://dxr.mozilla.org/mozilla-central/rev/8d0aadfe7da782d415363880008b4ca027686137/layout/generic/nsBlockFrame.cpp#127-214

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

If anyone wants to fix this bug by merging the existing flags in nsBlockDebugFlags.h into GECKO_BLOCK_DEBUG_FLAGS in nsBlockFrame, please see bug 1202758 comment 3 and do some archaeology to prevent the context being lost.