Closed
Bug 1276216
Opened 5 years ago
Closed 5 years ago
All tasks with no other dependencies should depend on the decision task
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
Details
Attachments
(2 files)
4.79 KB,
patch
|
Details | Diff | Splinter Review | |
58 bytes,
text/x-review-board-request
|
ahal
:
review+
|
Details |
This will fix a few things: * tasks that depend on the decision task's artifacts (e.g., context tarballs) * situations where the decision task crashes after creating a few tasks
Comment 1•5 years ago
|
||
If you modify an image the image task will fail due to this. Once the decision task is green, the image task can be retriggered and will succeed, but jobs that depended on the image task and are in the same push will fail. These jobs will start succeeding in subsequent pushes. The image task will also keep running (and failing) on subsequent pushes until the re-trigger comes back green.
Assignee | ||
Comment 2•5 years ago
|
||
I haven't found time to fix this since I'm at PyCon, but I'm sure I could find a few minutes to r+ a patch ;)
Comment 3•5 years ago
|
||
I think this can wait a few days, and it isn't actually blocking me on anything. I just wanted to document the expected results in case someone else ran into it (or saw my bug starring and was curious)
Assignee | ||
Comment 4•5 years ago
|
||
I made a patch for this on top of bug 1274611. Unfortunately, hg doesn't let you histedit anymore once you have other refs pointing to your tree, so I'm parking it here as a patch until that bug lands.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → dustin
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/58060/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58060/
Attachment #8760495 -
Flags: review?(ahalberstadt)
Comment 7•5 years ago
|
||
Comment on attachment 8760495 [details] Bug 1276216: make any tasks without dependencies depend on the decision task; https://reviewboard.mozilla.org/r/58060/#review55048 Thanks, lgtm! ::: taskcluster/taskgraph/create.py:30 (Diff revision 1) > + > for task_id in taskgraph.graph.visit_postorder(): > task_def = taskgraph.tasks[task_id].task > + > + # if this task has no dependencies, make it depend on this decision > + # taks so that it does not start immediately; and so that if this loop nit: task ::: taskcluster/taskgraph/test/test_create.py:39 (Diff revision 1) > + else: > + if 'TASK_ID' in os.environ: nit: elif
Attachment #8760495 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 8760495 [details] Bug 1276216: make any tasks without dependencies depend on the decision task; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58060/diff/1-2/
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d918f0e63889 make any tasks without dependencies depend on the decision task; r=ahal
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d918f0e63889
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•