1276216 - All tasks with no other dependencies should depend on the decision task

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

This will fix a few things:

 * tasks that depend on the decision task's artifacts (e.g., context tarballs)
 * situations where the decision task crashes after creating a few tasks

Comment 1

[Andrew Halberstadt [:ahal]]

If you modify an image the image task will fail due to this. Once the decision task is green, the image task can be retriggered and will succeed, but jobs that depended on the image task and are in the same push will fail. These jobs will start succeeding in subsequent pushes.

The image task will also keep running (and failing) on subsequent pushes until the re-trigger comes back green.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I haven't found time to fix this since I'm at PyCon, but I'm sure I could find a few minutes to r+ a patch ;)

Comment 3

[Andrew Halberstadt [:ahal]]

I think this can wait a few days, and it isn't actually blocking me on anything. I just wanted to document the expected results in case someone else ran into it (or saw my bug starring and was curious)

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: bug1276216.patch

I made a patch for this on top of bug 1274611.  Unfortunately, hg doesn't let you histedit anymore once you have other refs pointing to your tree, so I'm parking it here as a patch until that bug lands.

Comment 5

[Intermittent Failures Robot]

9 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 9

Platform breakdown:
* taskcluster-images: 5
* lint: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1276216&startday=2016-05-30&endday=2016-06-05&tree=all

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1276216: make any tasks without dependencies depend on the decision task;

Review commit: https://reviewboard.mozilla.org/r/58060/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58060/

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8760495 [details]
Bug 1276216: make any tasks without dependencies depend on the decision task;

https://reviewboard.mozilla.org/r/58060/#review55048

Thanks, lgtm!

::: taskcluster/taskgraph/create.py:30
(Diff revision 1)
> +
>      for task_id in taskgraph.graph.visit_postorder():
>          task_def = taskgraph.tasks[task_id].task
> +
> +        # if this task has no dependencies, make it depend on this decision
> +        # taks so that it does not start immediately; and so that if this loop

nit: task

::: taskcluster/taskgraph/test/test_create.py:39
(Diff revision 1)
> +        else:
> +            if 'TASK_ID' in os.environ:

nit: elif

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8760495 [details]
Bug 1276216: make any tasks without dependencies depend on the decision task;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58060/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d918f0e63889
make any tasks without dependencies depend on the decision task; r=ahal

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d918f0e63889