1276217 - Visual regressions in default newsletter embed forms

Status: RESOLVED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Alex Gibson [:agibson]]

Attachment: newsletter-styles.png

We recently updated the design for newsletter embed forms on many mozilla.org pages in Bug 1244200 and Bug 126396, and also the general button styles in Bug 1262099.

It looks like the default newsletter embed form, which is still present on various bedrock pages [e.g. 1], have suffered some minor visual regressions at smaller viewports (see attachment). We should probably fix these up.

[1] https://www.mozilla.org/en-US/contact/

Comment 1

[Allan]

I would like to fix this. Currently downloading the Git repo.

Comment 2

[Alex Gibson [:agibson]]

Thanks Allan!

Documentation for installing bedrock can be found here: http://bedrock.readthedocs.io/en/latest/install.html

If you have any questions, feel free to drop by #www on IRC and someone should be available to help.

Assigning this bug to you

Comment 3

[Allan]

Thanks Alex, should have this fixed and uploaded today, never having worked with bedrock - alot to take in! :)

Comment 4

[Alex Gibson [:agibson]]

Hi Allan,

Just checking in, are you still working on this bug?

Comment 5

[Alex Gibson [:agibson]]

Unassigned this bug due to inactivity. Allan, if you would like to pick this up again when you have time to work on it please comment here, else I'll leave this open for another contributor to work on. Thanks.

Comment 6

[Shashank Agarwal]

I would like to work on this bug

Comment 7

[Alex Gibson [:agibson]]

(In reply to Shashank Agarwal from comment #6)
> I would like to work on this bug

Thanks for showing interest in this bug, Shashank!

You can find information on how to setup bedrock locally here:

http://bedrock.readthedocs.io/en/latest/install.html

And here are our contributing guidelines:

http://bedrock.readthedocs.io/en/latest/contribute.html

Once you have bedrock working locally, please let me know and I'll assign this bug to you!

Thanks

Comment 8

[Alex Gibson [:agibson]]

If you have any trouble installing bedrock, best place to ask is #www on IRC.

Comment 9

[Utkarsh]

Hello Alex, I would like to fix this bug. I have cloned the git repo of bedrock and have it run locally.

Comment 10

[Shashank Agarwal]

Hi Alex, Sorry for the delay I have installed bedrock repository locally and ran it . So could you please assign the bug to me.

Comment 11

[Craig Cook (:craigcook)]

I'm going to assign this to Shashank since he expressed interest first and we'll find something else for Utkarsh to take on as his first official bug.

Comment 12

[Shashank Agarwal]

Thanks a lot Craig Cook. Already started working on the bug.

Comment 13

[Alex Gibson [:agibson]]

Ping Shashank - just checking in are you still working on this bug? If not please let me know and we can free it up for someone else to take on. Thanks

Comment 14

[Alex Gibson [:agibson]]

Unassigned this bug due to inactivity. If anyone else would like to take it on please feel free to inquire.

Comment 15

[Mainak Roy Chowdhury [:rcmainak]]

Is someone missing me? :D

Comment 16

[Mainak Roy Chowdhury [:rcmainak]]

Attachment: Proposed Patch

Comment 17

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/8761583736f041c483eb94e0e28ac472dee3c254
[Fix Bug 1276217] - Fix newsletter form layout for small viewports

Increased the input email width for mobile view. 
Decreased the .span_narrow of form-title by 1 unit.
Increased the .span_narrow of form-submit by 1 unit. (#4415)