Closed Bug 1276229 Opened 4 years ago Closed 4 years ago

Reps: Move PropRep Component into its own module

Categories

(DevTools :: Shared Components, defect, P1)

defect

Tracking

(firefox49 fixed)

RESOLVED FIXED
Firefox 49
Iteration:
49.3 - Jun 6
Tracking Status
firefox49 --- fixed

People

(Reporter: Honza, Assigned: Honza)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

Both Grip() rep and Obj() rep define its own helper PropRep component. The component is located in the same file (grip.js/object.js)


We should move out PropRep() component into its own file/module so:

- We follow our rule: one component per file
- Grip() and Obj() reps can share it and we avoid code duplication. 

Honza
Attached patch bug1276229.patchSplinter Review
Ryan, just a small code clean up (mainly to avoid code duplication)

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad2deb35365a

Honza
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Attachment #8758240 - Flags: review?(jryans)
Component: Developer Tools → Developer Tools: Shared Components
Product: Developer Documentation → Firefox
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/fx-team/rev/78e2125dfb6b
Move PropRep Component into its own module; r=jryans
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/78e2125dfb6b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Whiteboard: [devtools-html]
Iteration: --- → 49.3 - Jun 6
Flags: qe-verify-
Priority: -- → P1
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.