1276270 - Using back button to go back to a previous search result doesn't work

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[James Abbatiello]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

In a new tab, open https://dxr.mozilla.org/mozilla-central/search?q=AsyncShutdown .  You get a list of ~1000 results.

Add " components" to the end of the search bar.  The results filter down to ~35 and the URL changes to https://dxr.mozilla.org/mozilla-central/search?q=AsyncShutdown+components&redirect=false

Click "back".



Actual results:

The URL changes back to https://dxr.mozilla.org/mozilla-central/search?q=AsyncShutdown, but the search bar still contains "AsyncShutdown components" and the results still show the filtered results.

Clicking reload will "fix" this.



Expected results:

The URL should change back, the search bar should change back to just "AsyncShutdown" and the results should change back to the full list of results.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/b2c051a88893c422bb3c8e03684d6a430b7251dd
Reload on popState event every time the page being loaded is a search. (#550) Fixes bug 1276270.

This fixes the case where we start a new page with a search url (which doesn't
trigger a history push), and then search some more, and then go back.