Closed Bug 1276293 Opened 8 years ago Closed 8 years ago

respect Throttleable=0 in incoming crash reports

Categories

(Socorro :: General, task)

Product:
Socorro
Component:
General
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

From Peter's issue:

"""
When you submit crashes from about:crashes it sets Throttleable=0 in the form data. Our new throttler needs to respect this.

See https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/CrashSubmit.jsm#282
"""

https://github.com/mozilla/antenna/issues/31

This bug covers fixing the collector (or the new extracted collector) to respect that and automatically accept the incoming crash.
As a side note, I have no idea how often Socorro gets a crash report with this data item in it. Further I don't know what the circumstances around this data item are. Is this used by engineers? Is it used by users?

We probably want to track down someone who knows to answer these questions before we blindly implement this.
There are three things to do here:

1. figure out why that Throttleable thing was added, when it's used, what bug it was under, etc
2. document that all here
3. figure out how that affects the priority of when/if this should get worked on
Peter told me earlier today that the Throttelabe field has been there for a long time and that we probably never noticed Socorro doing the wrong thing because people most often submit crashes from about:crash from non-release version of Firefox which don't get throttled. That seems very plausible. However, that situation is no longer true.

Grabbing this to implement with the new collector. I might end up implementing it with the existing collector, too, depending on how long it takes to get the new collector out.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
This is implemented in Antenna now. It'll go live when we make Antenna the collector for Socorro.

Marking as FIXED.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.