Closed Bug 1276317 Opened 4 years ago Closed 4 years ago

Improve the handling of preferences in nsJSContext

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Whiteboard: btpp-active)

Attachments

(3 files)

We currently register a pref callback per nsJSContext which proceeds to set two static values and one thing on mContext... but the mContext thing is implemented on the JSRuntime anyway!  This is a bit silly.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8757539 - Flags: review?(jdemooij) → review+
Whiteboard: btpp-active
Attachment #8757540 - Flags: review?(peterv) → review+
Attachment #8757541 - Flags: review?(peterv) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5d63d08e347
part 1.  Change JS_SetGCZeal to take a JSRuntime, not a JSContext.  r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/48aedf3dbfd6
part 2.  Move GC zeal handling from nsJSContext to XPCJSRuntime.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fe18e6af534
part 3.  Move handling of the mem log prefs from being per-nsJSContext to just happening once in nsJSContext::EnsureStatics.  r=peterv
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.