1276317 - Improve the handling of preferences in nsJSContext

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We currently register a pref callback per nsJSContext which proceeds to set two static values and one thing on mContext... but the mContext thing is implemented on the JSRuntime anyway!  This is a bit silly.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Change JS_SetGCZeal to take a JSRuntime, not a JSContext

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Move GC zeal handling from nsJSContext to XPCJSRuntime

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Move handling of the mem log prefs from being per-nsJSContext to just happening once in nsJSContext::EnsureStatics

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5d63d08e347
part 1.  Change JS_SetGCZeal to take a JSRuntime, not a JSContext.  r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/48aedf3dbfd6
part 2.  Move GC zeal handling from nsJSContext to XPCJSRuntime.  r=peterv
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fe18e6af534
part 3.  Move handling of the mem log prefs from being per-nsJSContext to just happening once in nsJSContext::EnsureStatics.  r=peterv

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5d63d08e347
https://hg.mozilla.org/mozilla-central/rev/48aedf3dbfd6
https://hg.mozilla.org/mozilla-central/rev/2fe18e6af534