Compiling D3D11 Shaders Fails

RESOLVED FIXED in Firefox 49

Status

()

Core
Graphics: Layers
--
major
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kip, Assigned: kip)

Tracking

Trunk
mozilla49
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: gfx-noted)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Running the /gfx/layers/d3d11/genshaders.sh script fails with an error:

compilation failed; no code produced
c:\dev\mozilla-central\gfx\layers\d3d11\CompositorD3D11.hlsl(324,32-41): error X3004: undeclared identifier 'PS_MASK_2D'

I encountered this while updating shaders as part of Bug 1250244 (Implement WebVR 1.0 API).
(Assignee)

Comment 1

2 years ago
Created attachment 8757484 [details]
MozReview Request: Bug 1276359 - Fix D3D11 Shader Compile Failure

Review commit: https://reviewboard.mozilla.org/r/55914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55914/
(Assignee)

Updated

2 years ago
Attachment #8757484 - Flags: review?(jgilbert)
Comment on attachment 8757484 [details]
MozReview Request: Bug 1276359 - Fix D3D11 Shader Compile Failure

This needs to be :bas.
Attachment #8757484 - Flags: review?(jgilbert) → review?(bas)
MozReview didn't let me change the reviewer, so I just changed it here.
Component: Graphics → Graphics: Layers
Whiteboard: gfx-noted
Comment on attachment 8757484 [details]
MozReview Request: Bug 1276359 - Fix D3D11 Shader Compile Failure

https://reviewboard.mozilla.org/r/55914/#review52720
Attachment #8757484 - Flags: review?(bas) → review+

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bf99ab13bbbf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.