Closed Bug 1276359 Opened 8 years ago Closed 8 years ago

Compiling D3D11 Shaders Fails

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
major

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: kip, Assigned: kip)

References

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

MozReview Request: Bug 1276359 - Fix D3D11 Shader Compile Failure
58 bytes, text/x-review-board-request
bas.schouten
: review+
Details 
Running the /gfx/layers/d3d11/genshaders.sh script fails with an error:

compilation failed; no code produced
c:\dev\mozilla-central\gfx\layers\d3d11\CompositorD3D11.hlsl(324,32-41): error X3004: undeclared identifier 'PS_MASK_2D'

I encountered this while updating shaders as part of Bug 1250244 (Implement WebVR 1.0 API).
Attachment #8757484 - Flags: review?(jgilbert)
Comment on attachment 8757484 [details]
MozReview Request: Bug 1276359 - Fix D3D11 Shader Compile Failure

This needs to be :bas.
Attachment #8757484 - Flags: review?(jgilbert) → review?(bas)
MozReview didn't let me change the reviewer, so I just changed it here.
Component: Graphics → Graphics: Layers
Whiteboard: gfx-noted
Comment on attachment 8757484 [details]
MozReview Request: Bug 1276359 - Fix D3D11 Shader Compile Failure

https://reviewboard.mozilla.org/r/55914/#review52720
Attachment #8757484 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/bf99ab13bbbf
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.