1276371 - IP addresses not hidden on revision dashboard after first page of results

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Dashboards, defect)

Description

[Stephanie Hobson [:shobson]]

IP addresses are hidden by default on page 1 of the revision dashboard with a button to display them. On subsequent pages of results the IP addresses are displayed by default and pressing the toggle button doesn't do anything.

Comment 1

[Florian Scholz (Open Web Docs)]

teoli thinks there is a dupe, please find it :)

Comment 2

[Jean-Yves Perrier [:teoli]]

Ok, I found the bug I was thinking about: https://bugzilla.mozilla.org/show_bug.cgi?id=1126746

It is marked as fixed, so this is not a bug, but it may be a regression. I've added to my papercut trello column too.

Comment 3

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/b71558d01fe5ed7fa3d6f373f2ddfeaeee5c7903
Fix Bug 1276371: Hide IP address on dashboard after filter applied

Hide IP address by default on revision dashboard page, on all pages, not just first page of results.

- Moved dashboard javascript to external file and included file.
- Add hidden class to revision_ip to hide by default.
- Ensure toggle button has event listener attached to it after filters updated.
- Added 'table-layout:fixed' to stop table from moving around when IPs toggled into view.
- Fixed bug with keyboard navigation.
- Add interpolate() to .jshintrc as it is part of one of our global libraries like gettext.

https://github.com/mozilla/kuma/commit/96f13e0754e73dd87f9de2edbcc7bc42f139e5b4
Merge pull request #4023 from mozilla/1276371-ip-hide

Fix Bug 1276371: Hide IP address on dashboard after filter applied r=schalkneethling