If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Optimize document update a bit

RESOLVED FIXED in Firefox 49

Status

()

Core
DOM
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

36 Branch
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: btpp-active, URL)

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The array for script runners could use AutoTArray so that we don't end up allocating and releasing it all the time and a commonly used script runner could be cached.

My microbenchmark for this has been https://bug1275755.bmoattachments.org/attachment.cgi?id=8757475

Patch coming.
(Assignee)

Comment 1

a year ago
Created attachment 8757655 [details] [diff] [review]
patch

helps 5-10% locally on opt (but not pgo) build with that test case.

Changes to nsContentUtils reduce allocation/deallocation
and changes to nsDocument reduce both allocation/deallocation and AddRef/Release of nsDocument.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=b612524f332cdd4f105364cd233f94f8b347d198
Attachment #8757655 - Flags: review?(amarchesini)
Attachment #8757655 - Flags: review?(amarchesini) → review+

Comment 2

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a40ba00b9609
Whiteboard: btpp-active

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a40ba00b9609
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.