Closed Bug 1276477 Opened 3 years ago Closed 3 years ago

Optimize document update a bit

Categories

(Core :: DOM: Core & HTML, defect)

36 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

()

Details

(Whiteboard: btpp-active)

Attachments

(1 file)

The array for script runners could use AutoTArray so that we don't end up allocating and releasing it all the time and a commonly used script runner could be cached.

My microbenchmark for this has been https://bug1275755.bmoattachments.org/attachment.cgi?id=8757475

Patch coming.
Attached patch patchSplinter Review
helps 5-10% locally on opt (but not pgo) build with that test case.

Changes to nsContentUtils reduce allocation/deallocation
and changes to nsDocument reduce both allocation/deallocation and AddRef/Release of nsDocument.


https://treeherder.mozilla.org/#/jobs?repo=try&revision=b612524f332cdd4f105364cd233f94f8b347d198
Attachment #8757655 - Flags: review?(amarchesini)
Attachment #8757655 - Flags: review?(amarchesini) → review+
Whiteboard: btpp-active
https://hg.mozilla.org/mozilla-central/rev/a40ba00b9609
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.