Closed Bug 1276508 Opened 5 years ago Closed 5 years ago

Warning: Error in parsing value for 'background-color Source File: chrome://messenger/content/messengercompose/messengercompose.xul

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(thunderbird46 wontfix, thunderbird47 fixed, thunderbird48 fixed, thunderbird49 fixed, thunderbird_esr4547+ fixed)

RESOLVED FIXED
Thunderbird 49.0
Tracking Status
thunderbird46 --- wontfix
thunderbird47 --- fixed
thunderbird48 --- fixed
thunderbird49 --- fixed
thunderbird_esr45 47+ fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

This warning appears when opening a message in a window. The strange thing is, this happens only on Linux although Windows is doing the same.
Attached patch variableFix.patch (obsolete) — Splinter Review
Add sharedPlatform.css to messageWindow.css. OS X is not affected by this issue because it doesn't use variables here. I also moved the toolbars code from messenger.css to primaryToolbar.css to have the rules in the same files as OS X and Windows.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8757694 - Flags: review?(acelists)
Comment on attachment 8757694 [details] [diff] [review]
variableFix.patch

Review of attachment 8757694 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this solves the warnings for me.

Could you link in sharedPlatform.css on OS X too, for consistency, even if it is not used yet?
Attachment #8757694 - Flags: review?(acelists) → review+
(In reply to :aceman from comment #2)
> Comment on attachment 8757694 [details] [diff] [review]
> variableFix.patch
> 
> Review of attachment 8757694 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks, this solves the warnings for me.
> 
> Could you link in sharedPlatform.css on OS X too, for consistency, even if
> it is not used yet?

Then it's simpler to add it in the XUL file.
Attachment #8757694 - Attachment is obsolete: true
Attachment #8757702 - Flags: review?(acelists)
Can't it be imported into primaryToolbar.css where it is used? (The first patch imported into messageWindow.css).
Then it's two times imported on main window, in tabmail.css and primaryToolbar.css. messageWindow.css/xul is only used for the standalone window where is no tabmail.css (this is why I wrote, it's strange why it worked on Windows).

I'm planning to remove the sharedPlatform.css and move the variables to messenger.css. But I'm planning to uplift this bug and the planned changes are maybe to risky to made them now.
Comment on attachment 8757702 [details] [diff] [review]
variableFix.patch v2

Review of attachment 8757702 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8757702 - Flags: review?(acelists) → review+
http://hg.mozilla.org/comm-central/rev/80cff8d20b1b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
Comment on attachment 8757702 [details] [diff] [review]
variableFix.patch v2

[Approval Request Comment]
User impact if declined: incorrect toolbar background color on standalone window with LW-theme enabled
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low
Attachment #8757702 - Flags: approval-comm-esr45?
Attachment #8757702 - Flags: approval-comm-beta?
Attachment #8757702 - Flags: approval-comm-aurora?
Attachment #8757702 - Flags: approval-comm-aurora? → approval-comm-aurora+
Comment on attachment 8757702 [details] [diff] [review]
variableFix.patch v2

http://hg.mozilla.org/releases/comm-beta/rev/400a26ec0828
Attachment #8757702 - Flags: approval-comm-beta? → approval-comm-beta+
Comment on attachment 8757702 [details] [diff] [review]
variableFix.patch v2

http://hg.mozilla.org/releases/comm-esr45/rev/b050956b8c55
Attachment #8757702 - Flags: approval-comm-esr45? → approval-comm-esr45+
You need to log in before you can comment on or make changes to this bug.