Closed Bug 1276569 Opened 3 years ago Closed 3 years ago

Some AudioStream code cleanup

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Since OpenCubeb() is always called synchronously inside Init(), we can remove some null checks about |mCubebStream| for we shouldn't continue using an abject which failed to init.
Assignee: nobody → jwwang
Blocks: 1274160
Comment on attachment 8757925 [details]
MozReview Request: Bug 1276569. Part 1 - remove null checks. r=kinetik.

https://reviewboard.mozilla.org/r/56292/#review53022
Attachment #8757925 - Flags: review?(kinetik) → review+
Comment on attachment 8757926 [details]
MozReview Request: Bug 1276569. Part 2 - merge StartUnlocked() with Start() r=kinetik.

https://reviewboard.mozilla.org/r/56294/#review53024
Attachment #8757926 - Flags: review?(kinetik) → review+
Comment on attachment 8757927 [details]
MozReview Request: Bug 1276569. Part 3 - replace use of MOZ_LOG with LOG. r=kinetik.

https://reviewboard.mozilla.org/r/56296/#review53026
Attachment #8757927 - Flags: review?(kinetik) → review+
Comment on attachment 8757928 [details]
MozReview Request: Bug 1276569. Part 4 - remove mStartTime. r=kinetik.

https://reviewboard.mozilla.org/r/56298/#review53028
Attachment #8757928 - Flags: review?(kinetik) → review+
Thanks!
You need to log in before you can comment on or make changes to this bug.