Closed
Bug 1276569
Opened 6 years ago
Closed 6 years ago
Some AudioStream code cleanup
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Since OpenCubeb() is always called synchronously inside Init(), we can remove some null checks about |mCubebStream| for we shouldn't continue using an abject which failed to init.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → jwwang
|
|
Assignee | |
Comment 1•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4380628abd13
|
|
Assignee | |
Comment 2•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/56292/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56292/
Attachment #8757925 -
Flags: review?(kinetik)
Attachment #8757926 -
Flags: review?(kinetik)
Attachment #8757927 -
Flags: review?(kinetik)
Attachment #8757928 -
Flags: review?(kinetik)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/56294/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56294/
|
|
Assignee | |
Comment 4•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/56296/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56296/
|
|
Assignee | |
Comment 5•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/56298/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56298/
|
||
Updated•6 years ago
|
Priority: -- → P2
|
||
Comment 6•6 years ago
|
||
Comment on attachment 8757925 [details] MozReview Request: Bug 1276569. Part 1 - remove null checks. r=kinetik. https://reviewboard.mozilla.org/r/56292/#review53022
Attachment #8757925 -
Flags: review?(kinetik) → review+
|
|
||
Comment 7•6 years ago
|
||
Comment on attachment 8757926 [details] MozReview Request: Bug 1276569. Part 2 - merge StartUnlocked() with Start() r=kinetik. https://reviewboard.mozilla.org/r/56294/#review53024
Attachment #8757926 -
Flags: review?(kinetik) → review+
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 8757927 [details] MozReview Request: Bug 1276569. Part 3 - replace use of MOZ_LOG with LOG. r=kinetik. https://reviewboard.mozilla.org/r/56296/#review53026
Attachment #8757927 -
Flags: review?(kinetik) → review+
|
|
||
Comment 9•6 years ago
|
||
Comment on attachment 8757928 [details] MozReview Request: Bug 1276569. Part 4 - remove mStartTime. r=kinetik. https://reviewboard.mozilla.org/r/56298/#review53028
Attachment #8757928 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 10•6 years ago
|
||
Thanks!
|
||
Comment 11•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/00e04e27ccdd https://hg.mozilla.org/integration/mozilla-inbound/rev/677a8c65e91b https://hg.mozilla.org/integration/mozilla-inbound/rev/2981353a3ae7 https://hg.mozilla.org/integration/mozilla-inbound/rev/eaf90fc6c082
|
||
Comment 12•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00e04e27ccdd https://hg.mozilla.org/mozilla-central/rev/677a8c65e91b https://hg.mozilla.org/mozilla-central/rev/2981353a3ae7 https://hg.mozilla.org/mozilla-central/rev/eaf90fc6c082
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•