1276630 - [Static Analysis][Uninitialized pointer field] In constructor PaintBGParams

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that |frame| and |layer| are not initialized. As we are trying to push this patch: Bug 525063 we must prepare our base code in order to be able to integrate it.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

Review commit: https://reviewboard.mozilla.org/r/56260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56260/

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8757901 [details]
MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

https://reviewboard.mozilla.org/r/56260/#review52946

r=dbaron, although at this point it seems like it would be better to pass the paint flags and composition op as well (and remove their default-initialization), probably in the same order that they're passed to the factory methods.  Would you mind writing an additional patch for that?

Comment 3

[Andi [:andi]]

Comment on attachment 8757901 [details]
MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56260/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd166af53b59
initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r=dbaron

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd166af53b59