[Static Analysis][Uninitialized pointer field] In constructor PaintBGParams

RESOLVED FIXED in Firefox 51

Status

()

Core
Layout
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla51
coverity
Points:
---

Firefox Tracking Flags

(firefox49 wontfix, firefox51 fixed)

Details

(Whiteboard: CID 1362110)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The Static Analysis tool Coverity added that |frame| and |layer| are not initialized. As we are trying to push this patch: Bug 525063 we must prepare our base code in order to be able to integrate it.
(Assignee)

Comment 1

2 years ago
Created attachment 8757901 [details]
MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

Review commit: https://reviewboard.mozilla.org/r/56260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/56260/
Attachment #8757901 - Flags: review?(dbaron)
Comment on attachment 8757901 [details]
MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

https://reviewboard.mozilla.org/r/56260/#review52946

r=dbaron, although at this point it seems like it would be better to pass the paint flags and composition op as well (and remove their default-initialization), probably in the same order that they're passed to the factory methods.  Would you mind writing an additional patch for that?
Attachment #8757901 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

2 years ago
Comment on attachment 8757901 [details]
MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/56260/diff/1-2/
Attachment #8757901 - Attachment description: MozReview Request: Bug 1276630 - initialize member variables |frame| and |layer|. r?dbaron → MozReview Request: Bug 1276630 - initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r?dbaron

Comment 4

2 years ago
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd166af53b59
initialize member variables |frame|, |layer| and removed default-initialization for |paintFlags| and |compositionOp|. r=dbaron

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd166af53b59
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
status-firefox49: affected → wontfix
You need to log in before you can comment on or make changes to this bug.