Closed Bug 1276635 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized pointer field] In constructor nsAsyncRedirectVerifyHelper

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1362109)

Attachments

(1 file)

The Static Analysis tool Coverity added that |mFlags| and |mWaitingForRedirectCallback| are not initialized. As we are trying to push this patch: Bug 525063 we must prepare our base code in order to be able to integrate it
Comment on attachment 8757906 [details]
MozReview Request: Bug 1276635 - initialize member variables |mFlags| and |mWaitingForRedirectCallback|. r?valentin

https://reviewboard.mozilla.org/r/56272/#review52886

mCallbackInitiated not being initialized is obviously a bug, even though I don't know if it could happen at the moment.
This is really great work! Thanks!
Attachment #8757906 - Flags: review?(valentin.gosu) → review+
https://hg.mozilla.org/mozilla-central/rev/c46e0dfad282
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.