Closed Bug 1276635 Opened 4 years ago Closed 4 years ago
[Static Analysis][Uninitialized pointer field] In constructor ns
Async Redirect Verify Helper
MozReview Request: Bug 1276635 - initialize member variables |mFlags| and |mWaitingForRedirectCallback|. r?valentin
58 bytes, text/x-review-board-request
The Static Analysis tool Coverity added that |mFlags| and |mWaitingForRedirectCallback| are not initialized. As we are trying to push this patch: Bug 525063 we must prepare our base code in order to be able to integrate it
Review commit: https://reviewboard.mozilla.org/r/56272/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/56272/
Attachment #8757906 - Flags: review?(valentin.gosu)
Comment on attachment 8757906 [details] MozReview Request: Bug 1276635 - initialize member variables |mFlags| and |mWaitingForRedirectCallback|. r?valentin https://reviewboard.mozilla.org/r/56272/#review52886 mCallbackInitiated not being initialized is obviously a bug, even though I don't know if it could happen at the moment. This is really great work! Thanks!
Attachment #8757906 - Flags: review?(valentin.gosu) → review+
You need to log in before you can comment on or make changes to this bug.