Closed Bug 12767 Opened 25 years ago Closed 25 years ago

do not do extern C over include files

Categories

(Core :: Networking: Cookies, defect, P3)

Product:
Core
Component:
Networking: Cookies
Platform:
Sun
Solaris
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: Dan.Oscarsson, Assigned: morse)

Details

You should not place an extern C over include files.
See:   http://www.mozilla.org/docs/tplist/catBuild/portable-cpp.html
As a minimum you can fix the file as below.

*** mozilla/extensions/cookie/nsCookie.cpp.org  Sat Aug 28 13:48:11 1999
--- mozilla/extensions/cookie/nsCookie.cpp      Sat Aug 28 13:48:21 1999
***************
*** 30,37 ****
  #include "nsIStringBundle.h"
  #include "nsVoidArray.h"

- extern "C" {
  #include "prefapi.h"
  #include "prmon.h"
  #ifdef XP_MAC
  #include "prpriv.h"             /* for NewNamedMonitor */
--- 30,37 ----
  #include "nsIStringBundle.h"
  #include "nsVoidArray.h"

  #include "prefapi.h"
+ extern "C" {
  #include "prmon.h"
  #ifdef XP_MAC
  #include "prpriv.h"             /* for NewNamedMonitor */
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.