Add support to gfxConfig for blacklisting GLX surface sharing

NEW
Assigned to

Status

()

2 years ago
2 years ago

People

(Reporter: acomminos, Assigned: acomminos)

Tracking

(Blocks: 1 bug, {feature})

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We should add support for blacklisting GLX surface sharing based on the reported renderer string to gfxConfig.
This should block bug 1275725, since we should ship something like this without being able to blacklist drivers.

It should be sufficient to just add a normal blacklist entry. (similar to FEATURE_WEBGL_OPENGL)
Blocks: 1275725
No longer depends on: 1275725
Specifically, this probably doesn't need to be done in gfxConfig, but rather just in the normal blacklisting code.
(Assignee)

Comment 3

2 years ago
Created attachment 8759363 [details]
Bug 1276708 - Add gfxConfig feature for GLX surface sharing.

Review commit: https://reviewboard.mozilla.org/r/57366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57366/
Attachment #8759363 - Flags: review?(jmuizelaar)
(Assignee)

Comment 4

2 years ago
Fairly simple addition of a gfxConfig feature for managing surface sharing. All places the feature is checked can reasonably expect the GLX library to be initialized.

It's currently not very necessary to ensure that this feature is synchronized between content and chrome processes, but it might be a good idea later if we decide to disable the feature at runtime due to a failure in the compositor's texture host.
Comment on attachment 8759363 [details]
Bug 1276708 - Add gfxConfig feature for GLX surface sharing.

https://reviewboard.mozilla.org/r/57366/#review54380
Attachment #8759363 - Flags: review?(jmuizelaar) → review+
Keywords: feature
You need to log in before you can comment on or make changes to this bug.