ensure all search partner plugins are covered by automated testing

RESOLVED FIXED in Firefox 69

Status

()

task
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: mconnor, Unassigned)

Tracking

unspecified
Firefox 69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [partner search] [fixed by bug 1541196])

Not having this is a business risk. We should fix this once we can.
Blocks: 1276745
Whiteboard: [partner search] [fxsearch]
So now that we have all of the search engines checked into mozilla-central, we'd like to figure out a way to test all of our partner engines, including non en-US engines.

Currently because our default build is en-US and engines are bundled into the build based on the locale, the en-US build doesn't even have access to engines from other locales in order to run the tests, so we can't fake it by changing resource://search-plugins URLs or the geoSpecificDefaultsURL pref.

So at this point, I'm looking for ideas as to how we can solve this.

My only thought right now is that we somehow do a custom test build that includes all of the engines and use that for the testing. I'm not sure how that would work though.
(In reply to Mike Kaply [:mkaply] from comment #1)
> My only thought right now is that we somehow do a custom test build that
> includes all of the engines and use that for the testing. I'm not sure how
> that would work though.

That would be hard, since you can't have install two searchplugins with the same name, so you would need to modify the original XML file.

On how to fix this, I'm honestly short of ideas. How are search engines currently tested?
(In reply to Mike Kaply [:mkaply] from comment #1)
> So now that we have all of the search engines checked into mozilla-central,
> we'd like to figure out a way to test all of our partner engines, including
> non en-US engines.
> 
> Currently because our default build is en-US and engines are bundled into
> the build based on the locale, the en-US build doesn't even have access to
> engines from other locales in order to run the tests, so we can't fake it by
> changing resource://search-plugins URLs or the geoSpecificDefaultsURL pref.
> 
> So at this point, I'm looking for ideas as to how we can solve this.

You need the test to have access to a folder containing all the search plugins, and a list.json file that includes all of them.
This can't be part of the build we ship, so it'll need to be support files for the test.

Then the test needs to override resource://search-plugins to point to that folder.
Whiteboard: [partner search] [fxsearch] → [partner search]

We've now added tests for these engines via bug 1541196.

Status: NEW → RESOLVED
Type: defect → task
Closed: 2 months ago
Depends on: 1541196
Resolution: --- → FIXED
Whiteboard: [partner search] → [partner search] [fixed by bug 1541196]
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.