1276741 - ensure all search partner plugins are covered by automated testing

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mike Connor [:mconnor]]

Not having this is a business risk. We should fix this once we can.

Comment 1

[Mike Kaply [:mkaply] (Out until 9/29)]

So now that we have all of the search engines checked into mozilla-central, we'd like to figure out a way to test all of our partner engines, including non en-US engines.

Currently because our default build is en-US and engines are bundled into the build based on the locale, the en-US build doesn't even have access to engines from other locales in order to run the tests, so we can't fake it by changing resource://search-plugins URLs or the geoSpecificDefaultsURL pref.

So at this point, I'm looking for ideas as to how we can solve this.

My only thought right now is that we somehow do a custom test build that includes all of the engines and use that for the testing. I'm not sure how that would work though.

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #1)
> My only thought right now is that we somehow do a custom test build that
> includes all of the engines and use that for the testing. I'm not sure how
> that would work though.

That would be hard, since you can't have install two searchplugins with the same name, so you would need to modify the original XML file.

On how to fix this, I'm honestly short of ideas. How are search engines currently tested?

Comment 3

[Florian Quèze [:florian] (on leave until October 9)]

(In reply to Mike Kaply [:mkaply] from comment #1)
> So now that we have all of the search engines checked into mozilla-central,
> we'd like to figure out a way to test all of our partner engines, including
> non en-US engines.
> 
> Currently because our default build is en-US and engines are bundled into
> the build based on the locale, the en-US build doesn't even have access to
> engines from other locales in order to run the tests, so we can't fake it by
> changing resource://search-plugins URLs or the geoSpecificDefaultsURL pref.
> 
> So at this point, I'm looking for ideas as to how we can solve this.

You need the test to have access to a folder containing all the search plugins, and a list.json file that includes all of them.
This can't be part of the build we ship, so it'll need to be support files for the test.

Then the test needs to override resource://search-plugins to point to that folder.

Comment 4

[Mark Banner (:standard8)]

We've now added tests for these engines via bug 1541196.