1276839 - IonMonkey: MIPS64: Fix ma_dins encoding

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

For these instruction, the values of pos and size must satisfy all of the following relations:

dins:
0 ≤ pos < 32
0 < size ≤ 32
0 < pos+size ≤ 32

dinsm:
0 ≤ pos < 32
2 ≤ size ≤ 64
32 < pos+size ≤ 64

dinsu:
32 ≤ pos < 64
1 ≤ size ≤ 32
32 < pos+size ≤ 64

Comment 1

[hev [:hev]]

Attachment: 0001-Bug-1276839-IonMonkey-MIPS64-Fix-ma_dins-encoding.-r.patch

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8758099 [details] [diff] [review]
0001-Bug-1276839-IonMonkey-MIPS64-Fix-ma_dins-encoding.-r.patch

Review of attachment 8758099 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! :)

::: js/src/jit/mips64/MacroAssembler-mips64.cpp
@@ +344,4 @@
>  MacroAssemblerMIPS64::ma_dins(Register rt, Register rs, Imm32 pos, Imm32 size)
>  {
>      if (pos.value >= 0 && pos.value < 32) {
> +        if ((pos.value + size.value) > 32)

please remove extra parentheses.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/698ef7cd0e60
IonMonkey: MIPS64: Fix ma_dins encoding. r=arai

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/698ef7cd0e60