Closed Bug 1276839 Opened 6 years ago Closed 6 years ago

IonMonkey: MIPS64: Fix ma_dins encoding

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: hev, Assigned: hev)

Details

Attachments

(1 file)

For these instruction, the values of pos and size must satisfy all of the following relations:

dins:
0 ≤ pos < 32
0 < size ≤ 32
0 < pos+size ≤ 32

dinsm:
0 ≤ pos < 32
2 ≤ size ≤ 64
32 < pos+size ≤ 64

dinsu:
32 ≤ pos < 64
1 ≤ size ≤ 32
32 < pos+size ≤ 64
Comment on attachment 8758099 [details] [diff] [review]
0001-Bug-1276839-IonMonkey-MIPS64-Fix-ma_dins-encoding.-r.patch

Review of attachment 8758099 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! :)

::: js/src/jit/mips64/MacroAssembler-mips64.cpp
@@ +344,4 @@
>  MacroAssemblerMIPS64::ma_dins(Register rt, Register rs, Imm32 pos, Imm32 size)
>  {
>      if (pos.value >= 0 && pos.value < 32) {
> +        if ((pos.value + size.value) > 32)

please remove extra parentheses.
Attachment #8758099 - Flags: review?(arai.unmht) → review+
Pushed by r@hev.cc:
https://hg.mozilla.org/integration/mozilla-inbound/rev/698ef7cd0e60
IonMonkey: MIPS64: Fix ma_dins encoding. r=arai
https://hg.mozilla.org/mozilla-central/rev/698ef7cd0e60
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.