1276855 - [TV 2.6] When receive PIN dismiss from smart system, sends error to client actively

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Description

[Eric Tsai (no more review request accepted)]

Currently we only handle when one client used PIN code, the other client send PIN code receives error (PIN expire).
This bug will actively send error when PIN code dismiss from smart system, no matter it's manually or timeout.

Comment 1

[Eric Tsai (no more review request accepted)]

Attachment: Patch 1. Handle PIN dismiss from system app

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

(In reply to Eric Tsai from comment #0)
> Currently we only handle when one client used PIN code, the other client
> send PIN code receives error (PIN expire).
> This bug will actively send error when PIN code dismiss from smart system,
> no matter it's manually or timeout.

Will the client that receives PIN-expired error trigger re-connect automatically?

Comment 3

[Eric Tsai (no more review request accepted)]

Yes, when receives PIN-expired error, client shows the error message on paring page. Then start reconnection to pairing page again.
chunmin: please correct me if client side's implementation detail is wrong.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8758179 [details] [review]
Patch 1. Handle PIN dismiss from system app

Thanks for the explanation, lgtm.

Comment 5

[Eric Tsai (no more review request accepted)]

Comment on attachment 8758179 [details] [review]
Patch 1. Handle PIN dismiss from system app

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1276855
User impact if declined: malfunction in some use case
Testing completed: self-tested
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: N/A

Comment 6

[Josh Cheng [:josh]]

Comment on attachment 8758179 [details] [review]
Patch 1. Handle PIN dismiss from system app

Approve for TV 2.6

Comment 7

[Gary Chen [:xeonchen]]

https://github.com/mozilla-b2g/gecko-b2g/commit/f0434fd31da962cf5198e159e3b186879359b328